Implement multimodule solution

Author: jevanlingen

src/main/java/org/openrewrite/java/migrate/jakarta/HasNoJakartaNullAnnotations.java

@@ -15,19 +15,21 @@
  */
 package org.openrewrite.java.migrate.jakarta;
 
+import lombok.Value;
 import org.jspecify.annotations.Nullable;
 import org.openrewrite.ExecutionContext;
 import org.openrewrite.ScanningRecipe;
 import org.openrewrite.Tree;
 import org.openrewrite.TreeVisitor;
-import org.openrewrite.java.JavaIsoVisitor;
+import org.openrewrite.java.marker.JavaProject;
 import org.openrewrite.java.search.FindAnnotations;
 import org.openrewrite.java.tree.J;
 import org.openrewrite.marker.SearchResult;
 
-import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.HashSet;
+import java.util.Set;
 
-public class HasNoJakartaNullAnnotations extends ScanningRecipe<AtomicBoolean> {
+public class HasNoJakartaNullAnnotations extends ScanningRecipe<HasNoJakartaNullAnnotations.Accumulator> {
     @Override
     public String getDisplayName() {
         return "Project has no Jakarta null annotations";
@@ -38,38 +40,43 @@ public String getDescription() {
         return "Search for @Nonnull and @Nullable annotations, mark all source as found if no annotations are found.";
     }
 
+    @Value
+    public static class Accumulator {
+        Set<JavaProject> projectsWithDependency;
+    }
+
     @Override
-    public AtomicBoolean getInitialValue(ExecutionContext ctx) {
-        return new AtomicBoolean();
+    public Accumulator getInitialValue(ExecutionContext ctx) {
+        return new Accumulator(new HashSet<>());
     }
 
     @Override
-    public TreeVisitor<?, ExecutionContext> getScanner(AtomicBoolean acc) {
-        return new JavaIsoVisitor<ExecutionContext>() {
+    public TreeVisitor<?, ExecutionContext> getScanner(HasNoJakartaNullAnnotations.Accumulator acc) {
+        return new TreeVisitor<Tree, ExecutionContext>() {
             @Override
-            public J.CompilationUnit visitCompilationUnit(J.CompilationUnit cu, ExecutionContext ctx) {
-                J.CompilationUnit c = super.visitCompilationUnit(cu, ctx);
-                if (!acc.get()) {
-                    if ((!FindAnnotations.find(c, "@jakarta.annotation.Nonnull", true).isEmpty()) ||
-                            (!FindAnnotations.find(c, "@jakarta.annotation.Nullable", true).isEmpty())) {
-                        acc.set(true);
-                    }
+            public Tree visit(@Nullable Tree tree, ExecutionContext ctx) {
+                assert tree != null;
+                if (tree instanceof J) {
+                    tree.getMarkers().findFirst(JavaProject.class)
+                            .filter(__ ->!FindAnnotations.find((J) tree, "@jakarta.annotation.Nonnull", true).isEmpty() ||
+                                    !FindAnnotations.find((J) tree, "@jakarta.annotation.Nullable", true).isEmpty())
+                            .ifPresent(it -> acc.getProjectsWithDependency().add(it));
                 }
-                return cu;
+                return tree;
             }
         };
     }
 
     @Override
-    public TreeVisitor<?, ExecutionContext> getVisitor(AtomicBoolean acc) {
+    public TreeVisitor<?, ExecutionContext> getVisitor(HasNoJakartaNullAnnotations.Accumulator acc) {
         return new TreeVisitor<Tree, ExecutionContext>() {
             @Override
             public Tree visit(@Nullable Tree tree, ExecutionContext ctx) {
                 assert tree != null;
-                if (!acc.get()) {
-                    return SearchResult.found(tree, "Project has no Jakarta null annotations");
-                }
-                return tree;
+                return tree.getMarkers().findFirst(JavaProject.class)
+                        .filter(it -> !acc.getProjectsWithDependency().contains(it))
+                        .map(__ -> SearchResult.found(tree, "Project has no Jakarta null annotations"))
+                        .orElse(tree);
             }
         };
     }

src/test/java/org/openrewrite/java/migrate/jakarta/JavaxToJakartaTest.java

@@ -24,6 +24,9 @@
 import org.openrewrite.test.RecipeSpec;
 import org.openrewrite.test.RewriteTest;
 
+import static org.openrewrite.gradle.Assertions.buildGradle;
+import static org.openrewrite.gradle.Assertions.settingsGradle;
+import static org.openrewrite.gradle.toolingapi.Assertions.withToolingApi;
 import static org.openrewrite.java.Assertions.*;
 import static org.openrewrite.maven.Assertions.pomXml;
 import static org.openrewrite.xml.Assertions.xml;
@@ -702,6 +705,7 @@ void projectWithSpringBoot3StarterWebShouldNotRemoveJakartaDependencyWhenUsingNu
                     <artifactId>demo</artifactId>
                     <version>0.0.1-SNAPSHOT</version>
                     <dependencies>
+                    <!--implementation 'jakarta.annotation:jakarta.annotation-api:1.3.5'-->
                         <dependency>
                             <groupId>jakarta.annotation</groupId>
                             <artifactId>jakarta.annotation-api</artifactId>
@@ -734,6 +738,89 @@ public String safeUpperCase(@Nullable String input) {
         );
     }
 
+    @Test
+    void multiProjectWithSpringBoot3StarterWebShouldRemoveJakartaDependencyWhenUsingNullableAnnotationWhenApplicable() {
+        rewriteRun(
+          spec -> spec.beforeRecipe(withToolingApi()).parser(JavaParser.fromJavaVersion().dependsOn(javaxServlet, jakartaAnnotation)),
+          mavenProject("multi-project-build",
+            //language=groovy
+            settingsGradle("""
+              include 'project-with-null-annotations'
+              include 'project-without-null-annotations'
+              """),
+            mavenProject("project-with-null-annotations",
+              //language=groovy
+              buildGradle(
+                """
+                  plugins {
+                      id 'java'
+                      id 'org.springframework.boot' version '3.2.5'
+                      id 'io.spring.dependency-management' version '1.1.4'
+                  }
+
+                  dependencies {
+                      implementation 'jakarta.annotation:jakarta.annotation-api:1.3.5'
+                      implementation 'org.springframework.boot:spring-boot-starter-web'
+                  }
+                  """,
+                """
+                  plugins {
+                      id 'java'
+                      id 'org.springframework.boot' version '3.2.5'
+                      id 'io.spring.dependency-management' version '1.1.4'
+                  }
+
+                  dependencies {
+                      implementation 'jakarta.annotation:jakarta.annotation-api:2.0.0'
+                      implementation 'org.springframework.boot:spring-boot-starter-web'
+                  }
+                  """
+              ),
+              srcMainJava(
+                //language=java
+                java(
+                  """
+                    import jakarta.annotation.Nullable;
+
+                    public class TestApplication {
+                        @Nullable
+                        public String safeUpperCase(@Nullable String input) {
+                            return input == null ? null : input.toUpperCase();
+                        }
+                    }
+                    """
+                )
+              )
+            ),
+            mavenProject("project-without-null-annotations",
+              //language=groovy
+              buildGradle(
+                """
+                  plugins {
+                      id 'java'
+                      id 'org.springframework.boot' version '3.2.5'
+                      id 'io.spring.dependency-management' version '1.1.4'
+                  }
+
+                  dependencies {
+                      implementation 'jakarta.annotation:jakarta.annotation-api:1.3.5'
+                      implementation 'org.springframework.boot:spring-boot-starter-web'
+                  }
+                  """
+              )/*,
+              srcMainJava(
+                //language=java
+                java("""
+                  import jakarta.servlet.A;
+                  public class TestApplication {
+                  }
+                  """)
+              )*/
+            )
+          )
+        );
+    }
+
     @Test
     void upgradeAnnotationApiFromV1ToV2() {
         rewriteRun(