Slight polish

Author: timtebeek

src/main/java/org/openrewrite/java/migrate/lang/var/UseVarForGenericMethodInvocations.java

@@ -42,7 +42,7 @@ public String getDisplayName() {
     public String getDescription() {
         //language=markdown
         return "Apply `var` to variables initialized by invocations of generic methods. " +
-               "This recipe ignores generic factory methods without parameters, because open rewrite cannot handle them correctly ATM.";
+                "This recipe ignores generic factory methods without parameters, because open rewrite cannot handle them correctly ATM.";
     }
 
     @Override
@@ -119,7 +119,7 @@ private J.MethodInvocation makeNestedGenericsExplicit(J.MethodInvocation mi, J.V
                         // Copy type parameters from left side to right side
                         J.ParameterizedType rightType = (J.ParameterizedType) newClass.getClazz();
                         return newClass.withClazz(
-                            rightType.withTypeParameters(leftTypeParams)
+                                rightType.withTypeParameters(leftTypeParams)
                         );
                     }
                 }
@@ -129,7 +129,8 @@ private J.MethodInvocation makeNestedGenericsExplicit(J.MethodInvocation mi, J.V
 
         /**
          * Extract JavaTypes from a NewClass expression's type parameters.
-         * Returns null if not a parameterized type, or an empty list for diamond operator.
+         *
+         * @return null if not a parameterized type, or an empty list for diamond operator.
          */
         private @Nullable List<JavaType> extractJavaTypes(J.NewClass newClass) {
             TypeTree clazz = newClass.getClazz();

src/test/java/org/openrewrite/java/migrate/lang/var/UseVarForGenericMethodInvocationsTest.java

@@ -18,6 +18,7 @@
 import org.junit.jupiter.api.Nested;
 import org.junit.jupiter.api.Test;
 import org.openrewrite.DocumentExample;
+import org.openrewrite.Issue;
 import org.openrewrite.test.RecipeSpec;
 import org.openrewrite.test.RewriteTest;
 
@@ -260,81 +261,36 @@ void m() {
             );
         }
 
+        @Issue("https://github.com/openrewrite/rewrite-migrate-java/issues/862")
         @Test
         void nestedGenericsSimple() {
             //language=java
             rewriteRun(
               version(
-                java("""
-                  package com.example.app;
-
-                  import java.util.ArrayList;
-                  import java.util.Collections;
-                  import java.util.List;
-
-                  class A {
-                    private void dostuff() {
-                        List<String> strs = Collections.synchronizedList(new ArrayList<>());
-                    }
-                  }
-                  """, """
-                  package com.example.app;
-
-                  import java.util.ArrayList;
-                  import java.util.Collections;
-                  import java.util.List;
-
-                  class A {
-                    private void dostuff() {
-                        var strs = Collections.synchronizedList(new ArrayList<String>());
-                    }
-                  }
-                  """),
-                10
-              )
-            );
-        }
-
-        @Test
-        void nestedGenericsWithMethodReference() {
-            //language=java
-            rewriteRun(
-              version(
-                java("""
-                  package com.example.app;
-
-                  import java.util.ArrayList;
-                  import java.util.Collections;
-                  import java.util.List;
-
-                  class A {
-                    private void dostuff() {
-                        List<String> strs = Collections.synchronizedList(new ArrayList<>());
-                        strs.forEach(this::soString);
-                    }
-
-                    private void soString(String s) {
-                        System.out.println(s);
-                    }
-                  }
-                  """, """
-                  package com.example.app;
-
-                  import java.util.ArrayList;
-                  import java.util.Collections;
-                  import java.util.List;
-
-                  class A {
-                    private void dostuff() {
-                        var strs = Collections.synchronizedList(new ArrayList<String>());
-                        strs.forEach(this::soString);
+                java(
+                  """
+                    import java.util.ArrayList;
+                    import java.util.Collections;
+                    import java.util.List;
+
+                    class A {
+                      void dostuff() {
+                          List<String> strs = Collections.synchronizedList(new ArrayList<>());
+                      }
                     }
-
-                    private void soString(String s) {
-                        System.out.println(s);
+                    """,
+                  """
+                    import java.util.ArrayList;
+                    import java.util.Collections;
+                    import java.util.List;
+
+                    class A {
+                      void dostuff() {
+                          var strs = Collections.synchronizedList(new ArrayList<String>());
+                      }
                     }
-                  }
-                  """),
+                    """
+                ),
                 10
               )
             );