refactor: Inline local variable assignments before return/throw

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.InlineVariable?organizationId=ODQ2MGExMTUtNDg0My00N2EwLTgzMGMtNGE1NGExMTBmZDkw

Co-authored-by: Moderne <[email protected]>

Author: 2 people

src/main/java/org/openrewrite/java/migrate/UseJavaUtilBase64.java

@@ -84,9 +84,8 @@ public J visitCompilationUnit(J.CompilationUnit cu, ExecutionContext ctx) {
 
                 c = (J.CompilationUnit) new ChangeType(sunPackage + ".BASE64Encoder", "java.util.Base64$Encoder", true)
                         .getVisitor().visitNonNull(c, ctx);
-                c = (J.CompilationUnit) new ChangeType(sunPackage + ".BASE64Decoder", "java.util.Base64$Decoder", true)
+                return (J.CompilationUnit) new ChangeType(sunPackage + ".BASE64Decoder", "java.util.Base64$Decoder", true)
                         .getVisitor().visitNonNull(c, ctx);
-                return c;
             }
 
             @Override

src/main/java/org/openrewrite/java/migrate/javax/AddJaxbRuntime.java

@@ -222,10 +222,9 @@ private Xml.Document jaxbDependencySwap(ExecutionContext ctx, Xml.Document d, St
                 glassfishJaxbRuntimeGroup, glassfishJaxbRuntimeArtifact,
                 sunJaxbRuntimeGroup, sunJaxbRuntimeArtifact, "2.3.x", null
         ).getVisitor().visitNonNull(d, ctx);
-        d = (Xml.Document) new org.openrewrite.maven.ChangeManagedDependencyGroupIdAndArtifactId(
+        return (Xml.Document) new org.openrewrite.maven.ChangeManagedDependencyGroupIdAndArtifactId(
                 glassfishJaxbRuntimeGroup, glassfishJaxbRuntimeArtifact,
                 sunJaxbRuntimeGroup, sunJaxbRuntimeArtifact, "2.3.x"
         ).getVisitor().visitNonNull(d, ctx);
-        return d;
     }
 }

src/main/java/org/openrewrite/java/migrate/javax/UseJoinColumnForMapping.java

@@ -73,9 +73,7 @@ public J.VariableDeclarations visitVariableDeclarations(J.VariableDeclarations m
                         J.VariableDeclarations joinColumn = (J.VariableDeclarations) new ChangeType(COLUMN, JOIN_COLUMN, false).getVisitor().visit(multiVariable, ctx, getCursor().getParentOrThrow());
                         joinColumn = (J.VariableDeclarations) new RemoveAnnotationAttribute(JOIN_COLUMN, "length").getVisitor().visit(joinColumn, ctx, getCursor().getParentOrThrow());
                         joinColumn = (J.VariableDeclarations) new RemoveAnnotationAttribute(JOIN_COLUMN, "precision").getVisitor().visit(joinColumn, ctx, getCursor().getParentOrThrow());
-                        joinColumn = (J.VariableDeclarations) new RemoveAnnotationAttribute(JOIN_COLUMN, "scale").getVisitor().visit(joinColumn, ctx, getCursor().getParentOrThrow());
-
-                        return joinColumn;
+                        return (J.VariableDeclarations) new RemoveAnnotationAttribute(JOIN_COLUMN, "scale").getVisitor().visit(joinColumn, ctx, getCursor().getParentOrThrow());
                     }
                 }
         );