OpenRewrite recipe best practices

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.recipes.rewrite.OpenRewriteRecipeBestPractices?organizationId=QUxML01vZGVybmUvTW9kZXJuZSArIE9wZW5SZXdyaXRl

Co-authored-by: Moderne <[email protected]>

Author: 2 people

src/main/java/org/openrewrite/java/migrate/guava/NoGuavaPredicate.java

@@ -15,7 +15,10 @@
  */
 package org.openrewrite.java.migrate.guava;
 
-import org.openrewrite.*;
+import org.openrewrite.ExecutionContext;
+import org.openrewrite.Preconditions;
+import org.openrewrite.Recipe;
+import org.openrewrite.TreeVisitor;
 import org.openrewrite.java.ChangeMethodName;
 import org.openrewrite.java.ChangeType;
 import org.openrewrite.java.JavaIsoVisitor;

src/main/resources/META-INF/rewrite/examples.yml

@@ -3422,6 +3422,50 @@ examples:
           }
       }
     language: java
+- description: '`NoGuavaPredicatesEqualToTest#predicatesEqualToToPredicateIsEqual`'
+  sources:
+  - before: |
+      import com.google.common.base.Predicate;
+      import com.google.common.base.Predicates;
+
+      class A {
+          public static Predicate<String> isHelloPredicate() {
+              return Predicates.equalTo("hello");
+          }
+      }
+    after: |
+      import java.util.function.Predicate;
+
+      class A {
+          public static Predicate<String> isHelloPredicate() {
+              return Predicate.isEqual("hello");
+          }
+      }
+    language: java
+- description: '`NoGuavaSetsFilterTest#replaceSetsFilter`'
+  sources:
+  - before: |
+      import java.util.Set;
+
+      import com.google.common.base.Predicate;
+      import com.google.common.collect.Sets;
+
+      class Test {
+          public static Set<Object> test(Set<Object> set, Predicate<Object> isNotNull) {
+              return Sets.filter(set, isNotNull);
+          }
+      }
+    after: |
+      import java.util.Set;
+      import java.util.function.Predicate;
+      import java.util.stream.Collectors;
+
+      class Test {
+          public static Set<Object> test(Set<Object> set, Predicate<Object> isNotNull) {
+              return set.stream().filter(isNotNull).collect(Collectors.toSet());
+          }
+      }
+    language: java
 - description: '`NoGuavaTest#moreObjectsFirstNonNullToObjectsRequireNonNullElse`'
   sources:
   - before: |
@@ -3510,6 +3554,35 @@ examples:
     language: java
 ---
 type: specs.openrewrite.org/v1beta/example
+recipeName: org.openrewrite.java.migrate.guava.NoGuavaCollections2Transform
+examples:
+- description: '`NoGuavaCollections2TransformTest#replaceCollections2Transform`'
+  sources:
+  - before: |
+      import java.util.Collection;
+
+      import com.google.common.base.Function;
+      import com.google.common.collect.Collections2;
+
+      class Test {
+          Iterable<Integer> test(Collection<String> collection, Function<String, Integer> toSize) {
+              return Collections2.transform(collection, toSize);
+          }
+      }
+    after: |
+      import java.util.Collection;
+      import java.util.stream.Collectors;
+
+      import com.google.common.base.Function;
+
+      class Test {
+          Iterable<Integer> test(Collection<String> collection, Function<String, Integer> toSize) {
+              return collection.stream().map(toSize).collect(Collectors.toList());
+          }
+      }
+    language: java
+---
+type: specs.openrewrite.org/v1beta/example
 recipeName: org.openrewrite.java.migrate.guava.NoGuavaCreateTempDir
 examples:
 - description: '`NoGuavaCreateTempDirTest#inMethodThrowingException`'
@@ -3703,6 +3776,35 @@ examples:
     language: java
 ---
 type: specs.openrewrite.org/v1beta/example
+recipeName: org.openrewrite.java.migrate.guava.NoGuavaIterablesTransform
+examples:
+- description: '`NoGuavaIterablesTransformTest#replaceIterablesTransform`'
+  sources:
+  - before: |
+      import java.util.Collection;
+
+      import com.google.common.base.Function;
+      import com.google.common.collect.Iterables;
+
+      class Test {
+          Iterable<Integer> test(Collection<String> collection, Function<String, Integer> toSize) {
+              return Iterables.transform(collection, toSize);
+          }
+      }
+    after: |
+      import java.util.Collection;
+      import java.util.stream.Collectors;
+
+      import com.google.common.base.Function;
+
+      class Test {
+          Iterable<Integer> test(Collection<String> collection, Function<String, Integer> toSize) {
+              return collection.stream().map(toSize).collect(Collectors.toList());
+          }
+      }
+    language: java
+---
+type: specs.openrewrite.org/v1beta/example
 recipeName: org.openrewrite.java.migrate.guava.NoGuavaListsNewArrayList
 examples:
 - description: '`NoGuavaListsNewArrayListTest#replaceWithNewArrayList`'
@@ -3920,35 +4022,6 @@ examples:
     language: java
 ---
 type: specs.openrewrite.org/v1beta/example
-recipeName: org.openrewrite.java.migrate.guava.NoGuavaSetsFilter
-examples:
-- description: '`NoGuavaSetsFilterTest#replaceSetsFilter`'
-  sources:
-  - before: |
-      import java.util.Set;
-
-      import com.google.common.base.Predicate;
-      import com.google.common.collect.Sets;
-
-      class Test {
-          public static Set<Object> test(Set<Object> set, Predicate<Object> isNotNull) {
-              return Sets.filter(set, isNotNull);
-          }
-      }
-    after: |
-      import java.util.Set;
-      import java.util.stream.Collectors;
-
-      import com.google.common.base.Predicate;
-
-      class Test {
-          public static Set<Object> test(Set<Object> set, Predicate<Object> isNotNull) {
-              return set.stream().filter(isNotNull).collect(Collectors.toSet());
-          }
-      }
-    language: java
----
-type: specs.openrewrite.org/v1beta/example
 recipeName: org.openrewrite.java.migrate.guava.NoGuavaSetsNewConcurrentHashSet
 examples:
 - description: '`NoGuavaSetsNewConcurrentHashSetTest#replaceWithNewConcurrentHashSet`'
@@ -4400,6 +4473,24 @@ examples:
 type: specs.openrewrite.org/v1beta/example
 recipeName: org.openrewrite.java.migrate.jakarta.JakartaEE10
 examples:
+- description: '`JakartaEE10Test#chainedJettyUpgradeEE10`'
+  sources:
+  - before: |
+      <project>
+          <modelVersion>4.0.0</modelVersion>
+          <groupId>com.example</groupId>
+          <artifactId>demo</artifactId>
+          <version>0.0.1-SNAPSHOT</version>
+          <dependencies>
+              <dependency>
+                  <groupId>org.eclipse.jetty.websocket</groupId>
+                  <artifactId>websocket-server</artifactId>
+                  <version>9.4.58.v20250814</version>
+              </dependency>
+          </dependencies>
+      </project>
+    path: pom.xml
+    language: xml
 - description: '`UpdateAnnotationAttributeJavaxToJakartaTest#replaceInterfaceName`'
   sources:
   - before: |

src/test/java/org/openrewrite/java/migrate/UpgradeToJava17Test.java

@@ -17,9 +17,6 @@
 
 import org.junit.jupiter.api.Test;
 import org.openrewrite.DocumentExample;
-import org.openrewrite.InMemoryExecutionContext;
-import org.openrewrite.Issue;
-import org.openrewrite.java.JavaParser;
 import org.openrewrite.java.marker.JavaVersion;
 import org.openrewrite.test.RecipeSpec;
 import org.openrewrite.test.RewriteTest;