apply pr feedback

Author: MBoegers

src/main/resources/META-INF/rewrite/jaxb-plugins.yml

@@ -1,5 +1,5 @@
 #
-# Copyright 2024 the original author or authors.
+# Copyright 2025 the original author or authors.
 # <p>
 # Licensed under the Moderne Source Available License (the "License");
 # you may not use this file except in compliance with the License.
@@ -26,11 +26,10 @@ recipeList:
       oldGroupId: org.jvnet.jax-ws-commons
       oldArtifactId: jaxws-maven-plugin
       newGroupId: com.sun.xml.ws
-      newVersion: 2.3.5
-  - org.openrewrite.maven.ChangePluginExecutions:
-      groupId: org.jvnet.jax-ws-commons
-      artifactId: jaxws-maven-plugin
-      executions: "<id>wsimport-from-jdk</id><phase>generate-sources</phase><goals><goal>wsimport</goal></goals>"
+      newVersion: 2.3.7
+  - org.openrewrite.xml.AddOrUpdateChildTag:
+      parentXPath: //plugin[artifactId='jaxws-maven-plugin']/executions/execution
+      newChildTag: <phase>generate-sources</phase>
   - org.openrewrite.xml.ChangeTagName:
-      elementName: '/project/build/plugins/plugin/executions/execution/configuration/nocompile'
+      elementName: //plugin[artifactId='jaxws-maven-plugin']/executions/execution/configuration/nocompile
       newName: xnocompile

src/test/java/org/openrewrite/java/migrate/maven/MigrateJaxwsMavenPluginTest.java

@@ -20,6 +20,7 @@
 import org.openrewrite.test.RecipeSpec;
 import org.openrewrite.test.RewriteTest;
 
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.openrewrite.maven.Assertions.pomXml;
 
 class MigrateJaxwsMavenPluginTest implements RewriteTest {
@@ -67,6 +68,18 @@ void migrateJaxwsPluginFromJvnetToSunXmlWs() {
                                   </execution>
                               </executions>
                           </plugin>
+                          <plugin>
+                              <groupId>org.apache.maven.plugins</groupId>
+                              <artifactId>maven-compiler-plugin</artifactId>
+                              <version>3.14.1</version>
+                              <executions>
+                                  <execution>
+                                      <configuration>
+                                          <nocompile>true</nocompile>
+                                      </configuration>
+                                  </execution>
+                              </executions>
+                          </plugin>
                       </plugins>
                   </build>
               </project>
@@ -82,7 +95,7 @@ void migrateJaxwsPluginFromJvnetToSunXmlWs() {
                           <plugin>
                               <groupId>com.sun.xml.ws</groupId>
                               <artifactId>jaxws-maven-plugin</artifactId>
-                              <version>2.3.5</version>
+                              <version>2.3.7</version>
                               <executions>
                                   <execution>
                                       <id>wsimport-from-jdk</id>
@@ -100,6 +113,19 @@ void migrateJaxwsPluginFromJvnetToSunXmlWs() {
                                           <xnocompile>true</xnocompile>
                                           <verbose>true</verbose>
                                       </configuration>
+                                      <phase>generate-sources</phase>
+                                  </execution>
+                              </executions>
+                          </plugin>
+                          <plugin>
+                              <groupId>org.apache.maven.plugins</groupId>
+                              <artifactId>maven-compiler-plugin</artifactId>
+                              <version>3.14.1</version>
+                              <executions>
+                                  <execution>
+                                      <configuration>
+                                          <nocompile>true</nocompile>
+                                      </configuration>
                                   </execution>
                               </executions>
                           </plugin>