Skip to content

Commit d9d02b2

Browse files
committed
fixup type validation syntax on tests, remove unnecessary ignoring of type validation on tests successfully validating types
1 parent 4151d8d commit d9d02b2

File tree

4 files changed

+6
-11
lines changed

4 files changed

+6
-11
lines changed

src/test/kotlin/org/openrewrite/java/migrate/logging/MigrateLoggerGlobalToGetGlobalTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ class MigrateLoggerGlobalToGetGlobalTest : JavaRecipeTest {
4848
}
4949
}
5050
""",
51-
skipEnhancedTypeValidation = true // fixme
51+
typeValidation = { methodInvocations = false }
5252
)
5353

5454
}

src/test/kotlin/org/openrewrite/java/migrate/logging/MigrateLoggerLogrbToUseResourceBundleTest.kt

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,7 @@ class MigrateLoggerLogrbToUseResourceBundleTest : JavaRecipeTest {
8787
logger.logrb(Level.parse("0"), "sourceClass", "sourceMethod", ResourceBundle.getBundle("bundleName"), "msg", new Object());
8888
}
8989
}
90-
""",
91-
skipEnhancedTypeValidation = true // fixme
90+
"""
9291
)
9392

9493
@Test
@@ -123,8 +122,7 @@ class MigrateLoggerLogrbToUseResourceBundleTest : JavaRecipeTest {
123122
logger.logrb(Level.parse("0"), "sourceClass", "sourceMethod", ResourceBundle.getBundle("bundleName"), "msg", objects);
124123
}
125124
}
126-
""",
127-
skipEnhancedTypeValidation = true // fixme
125+
"""
128126
)
129127

130128
@Test
@@ -157,8 +155,7 @@ class MigrateLoggerLogrbToUseResourceBundleTest : JavaRecipeTest {
157155
logger.logrb(Level.parse("0"), "sourceClass", "sourceMethod", ResourceBundle.getBundle("bundleName"), "msg", new Exception());
158156
}
159157
}
160-
""",
161-
skipEnhancedTypeValidation = true // fixme
158+
"""
162159
)
163160

164161
}

src/test/kotlin/org/openrewrite/java/migrate/net/MigrateURLDecoderDecodeTest.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,7 @@ class MigrateURLDecoderDecodeTest : JavaRecipeTest {
4848
String message = URLDecoder.decode(url, StandardCharsets.UTF_8);
4949
}
5050
}
51-
""",
52-
skipEnhancedTypeValidation = true // fixme
51+
"""
5352
)
5453

5554
}

src/test/kotlin/org/openrewrite/java/migrate/net/MigrateURLEncoderEncodeTest.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,7 @@ class MigrateURLEncoderEncodeTest : JavaRecipeTest {
4848
String message = URLEncoder.encode(url, StandardCharsets.UTF_8);
4949
}
5050
}
51-
""",
52-
skipEnhancedTypeValidation = true // fixme
51+
"""
5352
)
5453

5554
}

0 commit comments

Comments
 (0)