refactor: Equals avoids null

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.EqualsAvoidsNull?organizationId=ODQ2MGExMTUtNDg0My00N2EwLTgzMGMtNGE1NGExMTBmZDkw

Co-authored-by: Moderne <[email protected]>

Author: 2 people

src/main/java/org/openrewrite/java/migrate/BeanDiscovery.java

@@ -61,7 +61,7 @@ public Xml visitTag(Xml.Tag tag, ExecutionContext ctx) {
                 boolean hasBeanDiscoveryMode = false;
                 String idealVersion = null;
                 for (Xml.Attribute attribute : t.getAttributes()) {
-                    if (attribute.getKeyAsString().equals("bean-discovery-mode")) {
+                    if ("bean-discovery-mode".equals(attribute.getKeyAsString())) {
                         hasBeanDiscoveryMode = true;
                     } else if (attribute.getKeyAsString().endsWith("schemaLocation")) {
                         String schemaLocation = attribute.getValueAsString();

src/main/java/org/openrewrite/java/migrate/CastArraysAsListToList.java

@@ -75,7 +75,7 @@ public J visitTypeCast(J.TypeCast typeCast, ExecutionContext ctx) {
             String fullyQualifiedName = ((JavaType.FullyQualified) elementType).getFullyQualifiedName();
             J.ArrayType castType = (J.ArrayType) typeCast.getClazz().getTree();
 
-            if (fullyQualifiedName.equals("java.lang.Object") && !(castType.getElementType() instanceof J.ArrayType)) {
+            if ("java.lang.Object".equals(fullyQualifiedName) && !(castType.getElementType() instanceof J.ArrayType)) {
                 // we don't need to fix this case because toArray() does return Object[] type
                 return typeCast;
             }

src/main/java/org/openrewrite/java/migrate/joda/JodaTimeVisitor.java

@@ -183,7 +183,7 @@ public Javadoc visitReference(Javadoc.Reference reference, ExecutionContext ctx)
     @Override
     public @NonNull J visitFieldAccess(@NonNull J.FieldAccess fieldAccess, @NonNull ExecutionContext ctx) {
         J.FieldAccess f = (J.FieldAccess) super.visitFieldAccess(fieldAccess, ctx);
-        if (TypeUtils.isOfClassType(f.getType(), JODA_DATE_TIME_ZONE) && f.getSimpleName().equals("UTC")) {
+        if (TypeUtils.isOfClassType(f.getType(), JODA_DATE_TIME_ZONE) && "UTC".equals(f.getSimpleName())) {
             return JavaTemplate.builder("ZoneOffset.UTC")
                     .imports(JAVA_ZONE_OFFSET)
                     .build()

src/main/java/org/openrewrite/java/migrate/lang/StringFormatted.java

@@ -84,7 +84,7 @@ public J visitMethodInvocation(J.MethodInvocation methodInvocation, ExecutionCon
                 maybeRemoveImport("java.lang.String.format");
                 J.MethodInvocation mi = methodInvocation.withName(methodInvocation.getName().withSimpleName("formatted"));
                 mi = mi.withMethodType(methodInvocation.getMethodType().getDeclaringType().getMethods().stream()
-                        .filter(it -> it.getName().equals("formatted"))
+                        .filter(it -> "formatted".equals(it.getName()))
                         .findAny()
                         .orElse(null));
                 if (mi.getName().getType() != null) {

src/main/java/org/openrewrite/java/migrate/lang/var/DeclarationCheck.java

@@ -143,7 +143,7 @@ public static boolean initializedByTernary(J.VariableDeclarations vd) {
      */
     private static boolean isInsideMethod(Cursor cursor) {
         Object value = cursor
-                .dropParentUntil(p -> p instanceof J.MethodDeclaration || p instanceof J.ClassDeclaration || p.equals(Cursor.ROOT_VALUE))
+                .dropParentUntil(p -> p instanceof J.MethodDeclaration || p instanceof J.ClassDeclaration || Cursor.ROOT_VALUE.equals(p))
                 .getValue();
 
         boolean isNotRoot = !Cursor.ROOT_VALUE.equals(value);

src/test/java/org/openrewrite/java/migrate/joda/JodaTimeScannerTest.java

@@ -105,9 +105,9 @@ private void print(DateTime dt) {
         // The parameter 'dt' in the 'print' method is also unsafe because one of its method calls is unsafe.
         assertEquals(3, scanner.getAcc().getUnsafeVars().size());
         for (J.VariableDeclarations.NamedVariable var : scanner.getAcc().getUnsafeVars()) {
-            assertTrue(var.getSimpleName().equals("dtz") ||
-                       var.getSimpleName().equals("dt") ||
-                       var.getSimpleName().equals("dateTime")
+            assertTrue("dtz".equals(var.getSimpleName()) ||
+                       "dt".equals(var.getSimpleName()) ||
+                       "dateTime".equals(var.getSimpleName())
             );
         }
     }
@@ -142,7 +142,7 @@ public void foo(String city) {
         // The local variable dt is unsafe due to class var datetime.
         assertEquals(2, scanner.getAcc().getUnsafeVars().size());
         for (J.VariableDeclarations.NamedVariable var : scanner.getAcc().getUnsafeVars()) {
-            assertTrue(var.getSimpleName().equals("dateTime") || var.getSimpleName().equals("dt"));
+            assertTrue("dateTime".equals(var.getSimpleName()) || "dt".equals(var.getSimpleName()));
         }
     }