Don't use try/catch to handle null type

Author: timtebeek

src/main/java/org/openrewrite/java/migrate/guava/NoGuavaPredicatesEqualTo.java

@@ -25,6 +25,7 @@
 import org.openrewrite.java.ShortenFullyQualifiedTypeReferences;
 import org.openrewrite.java.search.UsesMethod;
 import org.openrewrite.java.tree.J;
+import org.openrewrite.java.tree.JavaType;
 
 import java.util.Objects;
 import java.util.Set;
@@ -60,17 +61,8 @@ public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, Execu
                             maybeRemoveImport("com.google.common.base.Predicates");
                             maybeAddImport("java.util.function.Predicate");
 
-                            try {
-                                String typeString = Objects.requireNonNull(method.getArguments().get(0).getType()).toString();
-                                J.MethodInvocation genericMethod = JavaTemplate.builder("Predicate.<" + typeString + ">isEqual(#{any(java.lang.Object)})")
-                                        .imports("java.util.function.Predicate")
-                                        .build()
-                                        .apply(getCursor(),
-                                                method.getCoordinates().replace(),
-                                                method.getArguments().get(0));
-                                doAfterVisit(ShortenFullyQualifiedTypeReferences.modifyOnly(genericMethod));
-                                return genericMethod;
-                            } catch (NullPointerException e) {
+                            JavaType argumentType = method.getArguments().get(0).getType();
+                            if (argumentType == null) {
                                 // Fallback if no type is found.
                                 return JavaTemplate.builder("Predicate.isEqual(#{any(java.lang.Object)})")
                                         .imports("java.util.function.Predicate")
@@ -79,6 +71,16 @@ public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, Execu
                                                 method.getCoordinates().replace(),
                                                 method.getArguments().get(0));
                             }
+
+                            String typeString = Objects.requireNonNull(argumentType).toString();
+                            J.MethodInvocation genericMethod = JavaTemplate.builder("Predicate.<" + typeString + ">isEqual(#{any(java.lang.Object)})")
+                                    .imports("java.util.function.Predicate")
+                                    .build()
+                                    .apply(getCursor(),
+                                            method.getCoordinates().replace(),
+                                            method.getArguments().get(0));
+                            doAfterVisit(ShortenFullyQualifiedTypeReferences.modifyOnly(genericMethod));
+                            return genericMethod;
                         }
                         return super.visitMethodInvocation(method, ctx);
                     }