Skip to content

Commit f06e270

Browse files
Apply suggestions from code review
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 parent c35b7d6 commit f06e270

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/main/java/org/openrewrite/java/migrate/lombok/ConvertGetter.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,9 +123,9 @@ static class FieldAnnotator extends JavaIsoVisitor<ExecutionContext> {
123123
Set<Finding> fieldsToDecorate;
124124

125125
private JavaTemplate getAnnotation(AccessLevel accessLevel) {
126-
JavaTemplate.Builder builder = AccessLevel.PUBLIC.equals(accessLevel)
127-
? JavaTemplate.builder("@Getter\n")
128-
: JavaTemplate.builder("@Getter(AccessLevel." + accessLevel.name() + ")\n")
126+
JavaTemplate.Builder builder = AccessLevel.PUBLIC.equals(accessLevel) ?
127+
JavaTemplate.builder("@Getter\n") :
128+
JavaTemplate.builder("@Getter(AccessLevel." + accessLevel.name() + ")\n")
129129
.imports("lombok.AccessLevel");
130130

131131
return builder

src/main/java/org/openrewrite/java/migrate/lombok/LombokUtils.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ public class LombokUtils {
3333
public static boolean isEffectivelyGetter(J.MethodDeclaration method) {
3434
boolean takesNoParameters = method.getParameters().get(0) instanceof J.Empty;
3535
boolean singularReturn = method.getBody() != null //abstract methods can be null
36-
&& method.getBody().getStatements().size() == 1
37-
&& method.getBody().getStatements().get(0) instanceof J.Return;
36+
&& method.getBody().getStatements().size() == 1 &&
37+
method.getBody().getStatements().get(0) instanceof J.Return;
3838

3939
if (takesNoParameters && singularReturn) {
4040
Expression returnExpression = ((J.Return) method.getBody().getStatements().get(0)).getExpression();
@@ -53,8 +53,8 @@ public static String deriveGetterMethodName(JavaType.Variable fieldType) {
5353

5454
final String fieldName = fieldType.getName();
5555

56-
boolean alreadyStartsWithIs = fieldName.length() >= 3
57-
&& fieldName.substring(0, 3).matches("is[A-Z]");
56+
boolean alreadyStartsWithIs = fieldName.length() >= 3 &&
57+
fieldName.substring(0, 3).matches("is[A-Z]");
5858

5959
if (isPrimitiveBoolean)
6060
if (alreadyStartsWithIs)

0 commit comments

Comments
 (0)