Support lombok getter/setter generation for multiple variables declared on a single line

[rojyates]

What problem are you trying to solve?

The current Lombok AddGetter and AddSetter recipes do not handle compound field declarations like:
private int x, y, z;

Describe the solution you'd like

Automatically split compound declarations into individual fields.
Generate getters and setters for each field.

Have you considered any alternatives or workarounds?

The workaround is to manually edit the affected files to split the variables onto separate lines.

An alternative would be:

• integrate SplitVariableDeclarations into the getter/setter recipes.
• ensure each field from a compound declaration receives its own accessor methods.

Additional context

• Auto Lombok Host @Getter/@Setter to class level if appropriate
  recipe might address this for the specific scenario where all fields can be converted, or it might need to consider the same scenario, but I don't believe it would cover all cases.

Are you interested in contributing this feature to OpenRewrite?

If time permits later but not at the moment.

[timtebeek]

hi @rojyates ; I suggest you run https://app.moderne.io/recipes/org.openrewrite.staticanalysis.MultipleVariableDeclarations just before running the AddGetter and AddSetter recipes; we could even look to inline that for the Lombok best practices recipe.

[rojyates]

Thanks for the suggestion @timtebeek. I'll add that to our doco for other teams to pick up. Would be good to have it as part of the main recipe though, since it produce uncompilable code at the moment.

[timtebeek]

Ah I wasn't aware, thanks; Here's a unit test that for now indeed shows we add the annotation twice:

    @Issue("https://github.com/openrewrite/rewrite-migrate-java/issues/876")
    @Test
    void multipleVariableDeclarations() {
        rewriteRun(// language=java
          java(
            """
              class A {

                  int foo, bar = 9;

                  public int getFoo() {
                      return foo;
                  }

                  public int getBar() {
                      return bar;
                  }
              }
              """,
            """
              import lombok.Getter;

              class A {

                  @Getter
                  int foo, bar = 9;
              }
              """
          )
        );
    }

[timtebeek]

• Picked up in Fix duplicate @Getter annotations on multiple variable declarations #877