refactor: Static imports for Collections and Collectors

Use this link to re-run the recipe: https://app.moderne.io/builder/m9HsHwu2Z?organizationId=ODQ2MGExMTUtNDg0My00N2EwLTgzMGMtNGE1NGExMTBmZDkw

Co-authored-by: Moderne <team@moderne.io>

Author: 2 people

rewrite-python/src/main/java/org/openrewrite/python/PythonParser.java

@@ -42,10 +42,11 @@
 import java.nio.file.Paths;
 import java.util.*;
 import java.util.concurrent.TimeUnit;
-import java.util.stream.Collectors;
 import java.util.stream.Stream;
 
 import static java.util.Objects.requireNonNull;
+import static java.util.stream.Collectors.joining;
+import static java.util.stream.Collectors.toList;
 
 @SuppressWarnings("unused")
 @RequiredArgsConstructor(access = AccessLevel.PRIVATE)
@@ -192,7 +193,7 @@ private void initializeRemoting(ExecutionContext ctx) throws IOException {
             if (!pythonPath.isEmpty()) {
                 Map<String, String> environment = processBuilder.environment();
                 environment.compute("PYTHONPATH", (k, current) ->
-                        (current != null ? current + File.pathSeparator : "") + pythonPath.stream().map(Path::toString).collect(Collectors.joining(File.pathSeparator)));
+                        (current != null ? current + File.pathSeparator : "") + pythonPath.stream().map(Path::toString).collect(joining(File.pathSeparator)));
             }
             if (logCompilationWarningsAndErrors) {
                 processBuilder.redirectOutput(ProcessBuilder.Redirect.INHERIT);
@@ -281,7 +282,7 @@ private static boolean verifyRemotingInstallation(Path dir, String executable, @
         }
 
         try (InputStream inputStream = requireNonNull(PythonParser.class.getClassLoader().getResourceAsStream("META-INF/python-requirements.txt"))) {
-            List<String> packages = new BufferedReader(new InputStreamReader(inputStream)).lines().filter(l -> !l.isEmpty()).collect(Collectors.toList());
+            List<String> packages = new BufferedReader(new InputStreamReader(inputStream)).lines().filter(l -> !l.isEmpty()).collect(toList());
 
             List<String> command = new ArrayList<>(Arrays.asList(executable, "-m", "pip", "install", "--target", dir.toString()));
             command.addAll(packages);

rewrite-python/src/main/java/org/openrewrite/python/style/Autodetect.java

@@ -25,15 +25,24 @@
 import org.openrewrite.style.NamedStyles;
 import org.openrewrite.style.Style;
 
-import java.util.*;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Map.Entry;
+import java.util.UUID;
+
+import static java.util.Collections.emptySet;
+import static java.util.Collections.max;
 
 public class Autodetect extends NamedStyles implements PythonStyle {
     public Autodetect(UUID id, Collection<Style> styles) {
         super(id,
                 "org.openrewrite.python.Autodetect",
                 "Auto-detected",
                 "Automatically detect styles from a repository's existing code.",
-                Collections.emptySet(),
+                emptySet(),
                 styles);
     }
 
@@ -96,7 +105,7 @@ private static class IndentStatistics {
         private final Map<Integer, Integer> countsByIndentSize = new HashMap<>();
 
         private <T> T keyWithHighestCount(Map<T, Integer> counts) {
-            int max = Collections.max(counts.values());
+            int max = max(counts.values());
             return counts.entrySet()
                     .stream()
                     .filter(entry -> entry.getValue() == max)

rewrite-python/src/main/java/org/openrewrite/python/style/IntelliJ.java

@@ -18,8 +18,8 @@
 import org.openrewrite.style.NamedStyles;
 
 import java.util.Arrays;
-import java.util.Collections;
 
+import static java.util.Collections.emptySet;
 import static org.openrewrite.Tree.randomId;
 
 
@@ -31,7 +31,7 @@ public IntelliJ() {
                 "org.openrewrite.python.style.IntelliJ",
                 "IntelliJ IDEA",
                 "IntelliJ IDEA default Python style.",
-                Collections.emptySet(),
+                emptySet(),
                 Arrays.asList(
                         spaces(),
                         wrappingAndBraces(),

rewrite-python/src/main/java/org/openrewrite/python/tree/Py.java

@@ -35,7 +35,8 @@
 import java.nio.file.Path;
 import java.util.List;
 import java.util.UUID;
-import java.util.stream.Collectors;
+
+import static java.util.stream.Collectors.toList;
 
 public interface Py extends J {
 
@@ -586,7 +587,7 @@ public List<ClassDeclaration> getClasses() {
                     .map(JRightPadded::getElement)
                     .filter(J.ClassDeclaration.class::isInstance)
                     .map(J.ClassDeclaration.class::cast)
-                    .collect(Collectors.toList());
+                    .collect(toList());
         }
 
         @Override

rewrite-python/src/main/java/org/openrewrite/python/tree/PySpace.java

@@ -22,9 +22,10 @@
 import org.openrewrite.marker.Markers;
 
 import java.util.ArrayList;
-import java.util.Collections;
 import java.util.List;
 
+import static java.util.Collections.emptyList;
+
 public final class PySpace {
 
     public static final class SpaceBuilder {
@@ -79,7 +80,7 @@ public Space build() {
             finishComment();
             Space space = Space.build(
                     initialWhitespace == null ? "" : initialWhitespace,
-                    comments == null ? Collections.emptyList() : comments
+                    comments == null ? emptyList() : comments
             );
             reset();
             return space;
@@ -139,7 +140,7 @@ public enum IndentEndMode {
     public static Space reindent(Space original, String indentWithoutNewline, IndentStartMode startMode, IndentEndMode endMode) {
 
         if (indentWithoutNewline.contains("\n")) {
-            throw new IllegalArgumentException("argument to `deindent` should not contain newline: " + Space.build(indentWithoutNewline, Collections.emptyList()));
+            throw new IllegalArgumentException("argument to `deindent` should not contain newline: " + Space.build(indentWithoutNewline, emptyList()));
         }
 
         if (indentWithoutNewline.isEmpty()) {
@@ -165,7 +166,7 @@ public static Space reindent(Space original, String indentWithoutNewline, Indent
                 break;
         }
 
-        Space space = Space.build(original.getWhitespace(), Collections.emptyList());
+        Space space = Space.build(original.getWhitespace(), emptyList());
 
         List<Comment> originalComments = original.getComments();
 
@@ -202,7 +203,7 @@ public static Space reindent(Space original, String indentWithoutNewline, Indent
 
     public static Space deindent(Space original, String indentWithoutNewline, IndentStartMode startMode, IndentEndMode endMode) {
         if (indentWithoutNewline.contains("\n")) {
-            throw new IllegalArgumentException("argument to `deindent` should not contain newline: " + Space.build(indentWithoutNewline, Collections.emptyList()));
+            throw new IllegalArgumentException("argument to `deindent` should not contain newline: " + Space.build(indentWithoutNewline, emptyList()));
         }
 
         if (indentWithoutNewline.isEmpty()) {
@@ -241,7 +242,7 @@ public static Space deindent(Space original, String indentWithoutNewline, Indent
             } else {
                 // weird coincidence; maybe not possible?
                 currentlyIndented = false;
-                space = Space.build(original.getWhitespace(), Collections.emptyList());
+                space = Space.build(original.getWhitespace(), emptyList());
             }
         } else if (original.getWhitespace().endsWith(indentWithNewline)) {
             currentlyIndented = true;
@@ -250,11 +251,11 @@ public static Space deindent(Space original, String indentWithoutNewline, Indent
                             // just keep the newline
                             0, original.getWhitespace().length() - indentWithoutNewline.length()
                     ),
-                    Collections.emptyList()
+                    emptyList()
             );
         } else {
             currentlyIndented = false;
-            space = Space.build(original.getWhitespace(), Collections.emptyList());
+            space = Space.build(original.getWhitespace(), emptyList());
         }
 
         List<Comment> originalComments = original.getComments();