Revert "refactor: Add a null method argument ChangeType constructor"

This reverts commit 8833d81.

Author: timtebeek

src/main/java/org/openrewrite/java/spring/NoRequestMappingAnnotation.java

@@ -103,7 +103,7 @@ public J.Annotation visitAnnotation(J.Annotation annotation, ExecutionContext ct
                 // Change the Annotation Type
                 maybeAddImport("org.springframework.web.bind.annotation." + resolvedRequestMappingAnnotationClassName);
                 a = (J.Annotation) new ChangeType("org.springframework.web.bind.annotation.RequestMapping",
-                        "org.springframework.web.bind.annotation." + resolvedRequestMappingAnnotationClassName, false, null)
+                        "org.springframework.web.bind.annotation." + resolvedRequestMappingAnnotationClassName, false)
                         .getVisitor().visit(a, ctx, getCursor().getParentOrThrow());
 
                 // if there is only one remaining argument now, and it is "path" or "value", then we can drop the key name

src/main/java/org/openrewrite/java/spring/RenameBean.java

@@ -114,8 +114,8 @@ public J.ClassDeclaration visitClassDeclaration(J.ClassDeclaration classDecl, Ex
                 if (beanNameExpression == null && isRelevantType(cd.getType()) && StringUtils.uncapitalize(cd.getSimpleName()).equals(oldName)) {
                     String newFullyQualifiedTypeName = cd.getType().getFullyQualifiedName()
                             .replaceAll("^((.+\\.)*)[^.]+$", "$1" + StringUtils.capitalize(newName));
-                    acc.add(new ChangeType(cd.getType().getFullyQualifiedName(), newFullyQualifiedTypeName, false, null).getVisitor());
-                    acc.add(new ChangeType(cd.getType().getFullyQualifiedName() + "Test", newFullyQualifiedTypeName + "Test", false, null).getVisitor());
+                    acc.add(new ChangeType(cd.getType().getFullyQualifiedName(), newFullyQualifiedTypeName, false).getVisitor());
+                    acc.add(new ChangeType(cd.getType().getFullyQualifiedName() + "Test", newFullyQualifiedTypeName + "Test", false).getVisitor());
                 }
 
                 // handle annotation renames

src/main/java/org/openrewrite/java/spring/boot2/ReplaceExtendWithAndContextConfiguration.java

@@ -89,7 +89,7 @@ public J.Annotation visitAnnotation(J.Annotation annotation, ExecutionContext ct
                             // Change the @ContextConfiguration annotation to @SpringJUnitConfig
                             maybeRemoveImport(FQN_CONTEXT_CONFIGURATION);
                             maybeAddImport(FQN_SPRING_JUNIT_CONFIG);
-                            a = (J.Annotation) new ChangeType(FQN_CONTEXT_CONFIGURATION, FQN_SPRING_JUNIT_CONFIG, false, null)
+                            a = (J.Annotation) new ChangeType(FQN_CONTEXT_CONFIGURATION, FQN_SPRING_JUNIT_CONFIG, false)
                                     .getVisitor().visitNonNull(a, ctx, getCursor().getParentOrThrow());
                             a = autoFormat(a, ctx);
                         }

src/main/java/org/openrewrite/java/spring/data/MigrateQuerydslJpaRepository.java

@@ -51,7 +51,7 @@ public TreeVisitor<?, ExecutionContext> getVisitor() {
             @Override
             public J visitCompilationUnit(J.CompilationUnit cu, ExecutionContext ctx) {
                 J.CompilationUnit c = (J.CompilationUnit) super.visitCompilationUnit(cu, ctx);
-                doAfterVisit(new ChangeType(originalFqn, targetFqn, false, null).getVisitor());
+                doAfterVisit(new ChangeType(originalFqn, targetFqn, false).getVisitor());
                 return c;
             }
 

src/main/java/org/openrewrite/java/spring/framework/MigrateInstantiationAwareBeanPostProcessorAdapter.java

@@ -62,7 +62,7 @@ public J.ClassDeclaration visitClassDeclaration(J.ClassDeclaration classDecl, Ex
             @Override
             public J.CompilationUnit visitCompilationUnit(J.CompilationUnit cu, ExecutionContext ctx) {
                 J.CompilationUnit compilationUnit = super.visitCompilationUnit(cu, ctx);
-                doAfterVisit(new ChangeType(fromExtendingFqn, toImplementsFqn, false, null).getVisitor());
+                doAfterVisit(new ChangeType(fromExtendingFqn, toImplementsFqn, false).getVisitor());
                 return compilationUnit;
             }
         });

src/main/java/org/openrewrite/java/spring/security5/AuthorizeHttpRequests.java

@@ -57,15 +57,15 @@ private void changeTypesAfterVisit() {
                 doAfterVisit(new ChangeType(
                         "org.springframework.security.config.annotation.web.configurers.ExpressionUrlAuthorizationConfigurer.ExpressionInterceptUrlRegistry",
                         "org.springframework.security.config.annotation.web.configurers.AuthorizeHttpRequestsConfigurer.AuthorizationManagerRequestMatcherRegistry",
-                        false, null).getVisitor());
+                        false).getVisitor());
                 doAfterVisit(new ChangeType(
                         "org.springframework.security.config.annotation.web.configurers.ExpressionUrlAuthorizationConfigurer",
                         "org.springframework.security.config.annotation.web.configurers.AuthorizeHttpRequestsConfigurer",
-                        false, null).getVisitor());
+                        false).getVisitor());
                 doAfterVisit(new ChangeType(
                         "org.springframework.security.config.annotation.web.configurers.AbstractInterceptUrlConfigurer",
                         "org.springframework.security.config.annotation.web.configurers.AuthorizeHttpRequestsConfigurer",
-                        false, null).getVisitor());
+                        false).getVisitor());
             }
 
             @Override

src/main/java/org/openrewrite/java/spring/util/concurrent/ListenableToCompletableFuture.java

@@ -32,7 +32,7 @@ public J.CompilationUnit visitCompilationUnit(J.CompilationUnit compilationUnit,
                 .getVisitor().visit(cu, ctx, getCursor().getParent());
         cu = (J.CompilationUnit) new ChangeType(
                 "org.springframework.util.concurrent.ListenableFuture",
-                "java.util.concurrent.CompletableFuture", null, null)
+                "java.util.concurrent.CompletableFuture", null)
                 .getVisitor().visit(cu, ctx, getCursor().getParent());
         return cu;
     }