OpenRewrite recipe best practices

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.recipes.rewrite.OpenRewriteRecipeBestPractices?organizationId=QUxML01vZGVybmUvTW9kZXJuZSArIE9wZW5SZXdyaXRl

Co-authored-by: Moderne <team@moderne.io>

Author: timtebeek

src/main/java/org/openrewrite/java/spring/SeparateApplicationYamlByProfile.java

@@ -16,7 +16,6 @@
 package org.openrewrite.java.spring;
 
 import lombok.Getter;
-import lombok.Value;
 import org.openrewrite.*;
 import org.openrewrite.internal.ListUtils;
 import org.openrewrite.yaml.DeleteProperty;

src/main/java/org/openrewrite/java/spring/security5/ConvertSecurityMatchersToSecurityMatcher.java

@@ -56,8 +56,8 @@ public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, Execu
                 J.MethodInvocation mi = super.visitMethodInvocation(method, ctx);
 
                 // Match antMatchers/mvcMatchers/regexMatchers whose select is requestMatchers() on HttpSecurity
-                if ((ANT_MATCHERS.matches(mi) || MVC_MATCHERS.matches(mi) || REGEX_MATCHERS.matches(mi))
-                        && mi.getSelect() instanceof J.MethodInvocation) {
+                if ((ANT_MATCHERS.matches(mi) || MVC_MATCHERS.matches(mi) || REGEX_MATCHERS.matches(mi)) &&
+                        mi.getSelect() instanceof J.MethodInvocation) {
                     J.MethodInvocation selectMi = (J.MethodInvocation) mi.getSelect();
                     if (REQUEST_MATCHERS.matches(selectMi) && selectMi.getSelect() != null) {
                         // Build method type for securityMatcher on HttpSecurity

src/main/resources/META-INF/rewrite/examples.yml

@@ -5044,6 +5044,45 @@ examples:
     language: java
 ---
 type: specs.openrewrite.org/v1beta/example
+recipeName: org.openrewrite.java.spring.security5.ConvertSecurityMatchersToSecurityMatcher
+examples:
+- description: '`ConvertSecurityMatchersToSecurityMatcherTest#requestMatchersAntMatchersToSecurityMatcher`'
+  sources:
+  - before: |
+      import org.springframework.context.annotation.Bean;
+      import org.springframework.context.annotation.Configuration;
+      import org.springframework.security.config.annotation.web.builders.HttpSecurity;
+      import org.springframework.security.config.annotation.web.configuration.EnableWebSecurity;
+      import org.springframework.security.web.SecurityFilterChain;
+
+      @Configuration
+      @EnableWebSecurity
+      class SecurityConfig {
+          @Bean
+          SecurityFilterChain securityFilterChain(HttpSecurity http) throws Exception {
+              http.requestMatchers().antMatchers("/oidc/*", "/events/syncs**");
+              return http.build();
+          }
+      }
+    after: |
+      import org.springframework.context.annotation.Bean;
+      import org.springframework.context.annotation.Configuration;
+      import org.springframework.security.config.annotation.web.builders.HttpSecurity;
+      import org.springframework.security.config.annotation.web.configuration.EnableWebSecurity;
+      import org.springframework.security.web.SecurityFilterChain;
+
+      @Configuration
+      @EnableWebSecurity
+      class SecurityConfig {
+          @Bean
+          SecurityFilterChain securityFilterChain(HttpSecurity http) throws Exception {
+              http.securityMatcher("/oidc/*", "/events/syncs**");
+              return http.build();
+          }
+      }
+    language: java
+---
+type: specs.openrewrite.org/v1beta/example
 recipeName: org.openrewrite.java.spring.security5.RenameNimbusdsJsonObjectPackageName
 examples:
 - description: '`RenameNimbusdsJsonObjectPackageNameTest#renamePackage`'
@@ -5865,6 +5904,31 @@ examples:
     language: java
 ---
 type: specs.openrewrite.org/v1beta/example
+recipeName: org.openrewrite.java.springdoc.CleanupRemainingSpringfox
+examples:
+- description: '`CleanupRemainingSpringfoxTest#removeOrphanedPrivateMethodsWithSpringfoxTypes`'
+  sources:
+  - before: |
+      import springfox.documentation.service.ApiInfo;
+
+      class SwaggerConfig {
+
+          public void publicMethod() {
+          }
+
+          private ApiInfo appInfo() {
+              return new ApiInfo("My API", "Description", "1.0", "", "", "", "");
+          }
+      }
+    after: |
+      class SwaggerConfig {
+
+          public void publicMethod() {
+          }
+      }
+    language: java
+---
+type: specs.openrewrite.org/v1beta/example
 recipeName: org.openrewrite.java.springdoc.MigrateSpringdocCommon
 examples:
 - description: '`MigrateSpringdocCommonTest#fixCustomiserAndGroupedOpenApi`'
@@ -5914,6 +5978,35 @@ examples:
     language: java
 ---
 type: specs.openrewrite.org/v1beta/example
+recipeName: org.openrewrite.java.springdoc.SpringFoxToSpringDoc
+examples:
+- description: '`SpringFoxToSpringDocJsonTypesTest#addTodoCommentToJsonSerializerConstructor`'
+  sources:
+  - before: |
+      import springfox.documentation.spring.web.json.JacksonModuleRegistrar;
+      import springfox.documentation.spring.web.json.JsonSerializer;
+      import java.util.List;
+
+      class SwaggerConfig {
+
+          public JsonSerializer jsonSerializer(List<JacksonModuleRegistrar> registrars) {
+              return new JsonSerializer(registrars);
+          }
+      }
+    after: |
+      import springfox.documentation.spring.web.json.JacksonModuleRegistrar;
+      import springfox.documentation.spring.web.json.JsonSerializer;
+      import java.util.List;
+
+      class SwaggerConfig {
+
+          public JsonSerializer jsonSerializer(List<JacksonModuleRegistrar> registrars) {
+              return /* TODO: springfox.documentation.spring.web.json types have no SpringDoc equivalent. Remove this Springfox-internal code and use Jackson ObjectMapper directly if JSON serialization is still needed. See https://springdoc.org/migrating-from-springfox.html for guidance. */ new JsonSerializer(registrars);
+          }
+      }
+    language: java
+---
+type: specs.openrewrite.org/v1beta/example
 recipeName: org.openrewrite.java.springdoc.UpgradeSpringDoc_2
 examples:
 - description: '`UpgradeSpringDoc2Test#upgradeMaven`'