Don't remove @ModelAttribute on methods

Author: jkschneider

src/main/java/org/openrewrite/spring/ImplicitWebAnnotationNames.java

@@ -51,7 +51,9 @@ public J visitAnnotation(J.Annotation annotation) {
         J.Annotation a = refactor(annotation, super::visitAnnotation);
 
         if(PARAM_ANNOTATIONS.stream().anyMatch(annClass -> isOfClassType(annotation.getType(), annClass)) &&
-                annotation.getArgs() != null && nameArgumentValue(annotation).isPresent()) {
+                annotation.getArgs() != null && nameArgumentValue(annotation).isPresent() &&
+                // ModelAttribute can be on methods as well as parameters
+                getCursor().getParentOrThrow().getTree() instanceof J.VariableDecls) {
             J.Annotation.Arguments args = a.getArgs();
 
             if (args == null) {
@@ -74,6 +76,7 @@ public J visitAnnotation(J.Annotation annotation) {
                 args = null;
             }
 
+
             nameArgumentValue(a).ifPresent(value -> andThen(new RenameVariable(
                     getCursor().getParentOrThrow().<J.VariableDecls>getTree().getVars().get(0),
                     (String) value.getValue())));

src/test/kotlin/org/openrewrite/spring/ImplicitWebAnnotationNamesTest.kt

@@ -99,4 +99,33 @@ class ImplicitWebAnnotationNamesTest {
             }
         """)
     }
+
+    @Test
+    fun dontRemoveModelAttributeOnMethods() {
+        val controller = jp.parse("""
+            import org.springframework.web.bind.annotation.*;
+            import java.util.*;
+            
+            public class UsersController {
+                @ModelAttribute("types")
+                public Collection<String> populateUserTypes() {
+                    return Arrays.asList("free", "premium");
+                }
+            }
+        """.trimIndent())
+
+        val fixed = controller.refactor().visit(ImplicitWebAnnotationNames()).fix().fixed
+
+        assertRefactored(fixed, """
+            import org.springframework.web.bind.annotation.*;
+            import java.util.*;
+            
+            public class UsersController {
+                @ModelAttribute("types")
+                public Collection<String> populateUserTypes() {
+                    return Arrays.asList("free", "premium");
+                }
+            }
+        """)
+    }
 }