Handle non-lambda arguments in SuccessFailureCallbackToBiConsumerVisitor (#929)

When addCallback() receives ternary expressions or other non-lambda
arguments, the visitor would throw a ClassCastException attempting to
cast J.Ternary to J.Lambda. Add instanceof checks before casting both
the success and failure callback arguments, returning early when
arguments are not lambdas.

Author: Jenson3210

src/main/java/org/openrewrite/java/spring/util/concurrent/SuccessFailureCallbackToBiConsumerVisitor.java

@@ -55,16 +55,25 @@ public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, Execu
                 return mi;
             }
 
+            if (!(mi.getArguments().get(0) instanceof J.Lambda)) {
+                return mi;
+            }
             J.Lambda successCallback = (J.Lambda) mi.getArguments().get(0);
 
             boolean isKafkaFailureCallback = false;
             J.Lambda failureCallback;
             if (mi.getArguments().get(1) instanceof J.TypeCast) {
+                J.TypeCast typeCast = (J.TypeCast) mi.getArguments().get(1);
+                if (!(typeCast.getExpression() instanceof J.Lambda)) {
+                    return mi;
+                }
                 // In this case, assume it's casted to `org.springframework.kafka.core.KafkaFailureCallback` only
-                failureCallback = (J.Lambda) ((J.TypeCast) mi.getArguments().get(1)).getExpression();
+                failureCallback = (J.Lambda) typeCast.getExpression();
                 isKafkaFailureCallback = true;
-            } else {
+            } else if (mi.getArguments().get(1) instanceof J.Lambda) {
                 failureCallback = (J.Lambda) mi.getArguments().get(1);
+            } else {
+                return mi;
             }
 
             J.Identifier successParam = ((J.VariableDeclarations) successCallback.getParameters().getParameters().get(0)).getVariables().get(0).getName();

src/test/java/org/openrewrite/java/spring/util/concurrent/ListenableToCompletableFutureTest.java

@@ -263,6 +263,41 @@ void test(CompletableFuture<String> future) {
         );
     }
 
+    @Test
+    void addSuccessFailureCallbackWithTernaryArguments() {
+        //language=java
+        rewriteRun(
+          java(
+            """
+              import org.springframework.util.concurrent.ListenableFuture;
+              import org.springframework.util.concurrent.SuccessCallback;
+              import org.springframework.util.concurrent.FailureCallback;
+              class A {
+                  void test(ListenableFuture<String> future, SuccessCallback<String> successCallback, FailureCallback failureCallback) {
+                      future.addCallback(
+                          successCallback != null ? result -> successCallback.onSuccess(result) : null,
+                          failureCallback != null ? ex -> failureCallback.onFailure(ex) : null);
+                  }
+              }
+              """,
+            """
+              import org.springframework.util.concurrent.SuccessCallback;
+              import org.springframework.util.concurrent.FailureCallback;
+
+              import java.util.concurrent.CompletableFuture;
+
+              class A {
+                  void test(CompletableFuture<String> future, SuccessCallback<String> successCallback, FailureCallback failureCallback) {
+                      future.whenComplete(
+                          successCallback != null ? result -> successCallback.onSuccess(result) : null,
+                          failureCallback != null ? ex -> failureCallback.onFailure(ex) : null);
+                  }
+              }
+              """
+          )
+        );
+    }
+
     @Test
     void addSuccessFailureCallbackWithTypeCast() {
         //language=java