Skip to content

Commit f9500bb

Browse files
committed
Exclude milestones from Maven Central as well
1 parent 9bb9bc9 commit f9500bb

File tree

4 files changed

+11
-7
lines changed

4 files changed

+11
-7
lines changed

.github/workflows/properties.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,8 @@ name: Generate Spring Boot property migration recipes
33

44
on:
55
workflow_dispatch: {}
6-
# Hold off on incomplete migration recipes for now
7-
# schedule:
8-
# - cron: 0 11 * * MON
6+
schedule:
7+
- cron: 0 11 * * TUE
98

109
jobs:
1110
update-migrations:

src/main/resources/META-INF/rewrite/spring-boot-35-properties.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,3 +106,4 @@ recipeList:
106106
- org.openrewrite.java.spring.CommentOutSpringPropertyKey:
107107
propertyKey: management.signalfx.metrics.export.uri
108108
comment: "This property is deprecated: Deprecated in Micrometer 1.15.0"
109+

src/test/java/org/openrewrite/java/spring/internal/GeneratePropertiesMigratorConfiguration.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public static void main(String[] args) throws IOException {
5656
for (String version : latestPatchReleases) {
5757
Version semanticVersion = new Version(version);
5858
// We only need to scan one outdated version to prevent duplicate migration recipes
59-
if (semanticVersion.compareTo(new Version("3.1")) < 0) {
59+
if (semanticVersion.compareTo(new Version("3.3")) < 0) {
6060
continue;
6161
}
6262
var versionDir = new File(releasesDir, version);
@@ -80,7 +80,7 @@ public static void main(String[] args) throws IOException {
8080
continue;
8181
}
8282
var majorMinor = version.split("\\.");
83-
if (semanticVersion.compareTo(new Version("3.2")) < 0) {
83+
if (semanticVersion.compareTo(new Version("3.5")) < 0) {
8484
// Don't override manual fixes to the unsupported 2.x and 3.0 versions anymore
8585
continue;
8686
}

src/test/java/org/openrewrite/java/spring/internal/SpringBootReleases.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,10 +123,14 @@ private Set<String> allReleases() {
123123
.matcher(new String(responseBody));
124124

125125
while (releaseMatcher.find()) {
126-
if ("..".equals(releaseMatcher.group(1))) {
126+
String release = releaseMatcher.group(1);
127+
if ("..".equals(release)) {
127128
continue;
128129
}
129-
releases.add(releaseMatcher.group(1));
130+
if ((release.contains("-RC") || release.contains("-M")) && !includeReleaseCandidates) {
131+
continue;
132+
}
133+
releases.add(release);
130134
}
131135
}
132136

0 commit comments

Comments
 (0)