Replace getEstimatedEffortPerOccurrence() method with field (#807)

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.recipes.UseEstimatedEffortPerOccurrenceField?organizationId=QUxML01vZGVybmUvTW9kZXJuZSArIE9wZW5SZXdyaXRl

Co-authored-by: Moderne <team@moderne.io>

Author: timtebeek

src/main/java/org/openrewrite/staticanalysis/AddSerialAnnotationToSerialVersionUID.java

@@ -42,10 +42,8 @@ public class AddSerialAnnotationToSerialVersionUID extends Recipe {
     @Getter
     final String description = "Annotate any `serialVersionUID` fields with `@Serial` to indicate it's part of the serialization mechanism.";
 
-    @Override
-    public Duration getEstimatedEffortPerOccurrence() {
-        return Duration.ofMinutes(1);
-    }
+    @Getter
+    final Duration estimatedEffortPerOccurrence = Duration.ofMinutes(1);
 
     @Override
     @NonNull

src/main/java/org/openrewrite/staticanalysis/BooleanChecksNotInverted.java

@@ -38,10 +38,8 @@ public class BooleanChecksNotInverted extends Recipe {
     @Getter
     final Set<String> tags = singleton("RSPEC-S1940");
 
-    @Override
-    public Duration getEstimatedEffortPerOccurrence() {
-        return Duration.ofMinutes(2);
-    }
+    @Getter
+    final Duration estimatedEffortPerOccurrence = Duration.ofMinutes(2);
 
     @Override
     public TreeVisitor<?, ExecutionContext> getVisitor() {

src/main/java/org/openrewrite/staticanalysis/ChainStringBuilderAppendCalls.java

@@ -42,10 +42,8 @@ public class ChainStringBuilderAppendCalls extends Recipe {
     @Getter
     final String description = "String concatenation within calls to `StringBuilder.append()` causes unnecessary memory allocation. Except for concatenations of String literals, which are joined together at compile time. Replaces inefficient concatenations with chained calls to `StringBuilder.append()`.";
 
-    @Override
-    public @Nullable Duration getEstimatedEffortPerOccurrence() {
-        return Duration.ofMinutes(2);
-    }
+    @Getter
+    final Duration estimatedEffortPerOccurrence = Duration.ofMinutes(2);
 
     @Override
     public TreeVisitor<?, ExecutionContext> getVisitor() {

src/main/java/org/openrewrite/staticanalysis/CollectionToArrayShouldHaveProperType.java

@@ -43,10 +43,8 @@ public class CollectionToArrayShouldHaveProperType extends Recipe {
     final String description = "Using `Collection.toArray()` without parameters returns an `Object[]`, which requires casting. " +
             "It is more efficient and clearer to use `Collection.toArray(new T[0])` instead.";
 
-    @Override
-    public Duration getEstimatedEffortPerOccurrence() {
-        return Duration.ofMinutes(2);
-    }
+    @Getter
+    final Duration estimatedEffortPerOccurrence = Duration.ofMinutes(2);
 
     @Getter
     final Set<String> tags = singleton("RSPEC-S3020");

src/main/java/org/openrewrite/staticanalysis/EqualsAvoidsNull.java

@@ -55,10 +55,7 @@ public class EqualsAvoidsNull extends Recipe {
 
     Set<String> tags = singleton("RSPEC-S1132");
 
-    @Override
-    public Duration getEstimatedEffortPerOccurrence() {
-        return ofMinutes(10);
-    }
+    Duration estimatedEffortPerOccurrence = ofMinutes(10);
 
     @Override
     public TreeVisitor<?, ExecutionContext> getVisitor() {

src/main/java/org/openrewrite/staticanalysis/ExplicitInitialization.java

@@ -42,10 +42,8 @@ public class ExplicitInitialization extends Recipe {
     @Getter
     final Set<String> tags = singleton("RSPEC-S3052");
 
-    @Override
-    public Duration getEstimatedEffortPerOccurrence() {
-        return Duration.ofMinutes(2);
-    }
+    @Getter
+    final Duration estimatedEffortPerOccurrence = Duration.ofMinutes(2);
 
     @Override
     public TreeVisitor<?, ExecutionContext> getVisitor() {

src/main/java/org/openrewrite/staticanalysis/ExternalizableHasNoArgsConstructor.java

@@ -44,10 +44,8 @@ public class ExternalizableHasNoArgsConstructor extends Recipe {
     @Getter
     final String description = "`Externalizable` classes handle both serialization and deserialization and must have a no-args constructor for the deserialization process.";
 
-    @Override
-    public Duration getEstimatedEffortPerOccurrence() {
-        return Duration.ofMinutes(20);
-    }
+    @Getter
+    final Duration estimatedEffortPerOccurrence = Duration.ofMinutes(20);
 
     @Getter
     final Set<String> tags = singleton("RSPEC-S2060");

src/main/java/org/openrewrite/staticanalysis/FallThrough.java

@@ -35,10 +35,8 @@ public class FallThrough extends Recipe {
     @Getter
     final Set<String> tags = singleton("RSPEC-S128");
 
-    @Override
-    public Duration getEstimatedEffortPerOccurrence() {
-        return Duration.ofMinutes(10);
-    }
+    @Getter
+    final Duration estimatedEffortPerOccurrence = Duration.ofMinutes(10);
 
     @Override
     public TreeVisitor<?, ExecutionContext> getVisitor() {

src/main/java/org/openrewrite/staticanalysis/FinalizePrivateFields.java

@@ -41,10 +41,8 @@ public class FinalizePrivateFields extends Recipe {
     @Getter
     final String description = "Adds the `final` modifier keyword to private instance variables which are not reassigned.";
 
-    @Override
-    public @Nullable Duration getEstimatedEffortPerOccurrence() {
-        return Duration.ofMinutes(2);
-    }
+    @Getter
+    final Duration estimatedEffortPerOccurrence = Duration.ofMinutes(2);
 
     @Override
     public TreeVisitor<?, ExecutionContext> getVisitor() {

src/main/java/org/openrewrite/staticanalysis/ForLoopIncrementInUpdate.java

@@ -45,10 +45,8 @@ public class ForLoopIncrementInUpdate extends Recipe {
     @Getter
     final Set<String> tags = singleton("RSPEC-S1994");
 
-    @Override
-    public Duration getEstimatedEffortPerOccurrence() {
-        return Duration.ofMinutes(20);
-    }
+    @Getter
+    final Duration estimatedEffortPerOccurrence = Duration.ofMinutes(20);
 
     @Override
     public TreeVisitor<?, ExecutionContext> getVisitor() {