TestNG matching for RemoveUnneededAssertion (#549)

* Adding matching for TestNG `assertTrue(..)` and `assertFalse(..)` for `RemoveUnneededAssertion`

* Nesting the tests into groups of which library of assertions are being used.

Author: steve-aom-elliott

build.gradle.kts

@@ -36,6 +36,7 @@ dependencies {
     testImplementation("org.jetbrains:annotations:24.+")
     testImplementation("org.junit-pioneer:junit-pioneer:2.+")
     testImplementation("junit:junit:4.13.2")
+    testImplementation("org.testng:testng:7.+")
 
     testImplementation("com.google.code.gson:gson:latest.release")
 

src/main/java/org/openrewrite/staticanalysis/RemoveUnneededAssertion.java

@@ -44,6 +44,10 @@ public class RemoveUnneededAssertion extends Recipe {
     private static final MethodMatcher JUNIT_ASSERT_MESSAGE_TRUE_MATCHER = new MethodMatcher("org.junit.Assert assertTrue(String, boolean)");
     private static final MethodMatcher JUNIT_ASSERT_MESSAGE_FALSE_MATCHER = new MethodMatcher("org.junit.Assert assertFalse(String, boolean)");
 
+    // TestNG
+    private static final MethodMatcher TEST_NG_ASSERT_TRUE_MATCHER = new MethodMatcher("org.testng.Assert assertTrue(..)");
+    private static final MethodMatcher TEST_NG_ASSERT_FALSE_MATCHER = new MethodMatcher("org.testng.Assert assertFalse(..)");
+
     @Override
     public String getDisplayName() {
         return "Remove unneeded assertions";
@@ -63,6 +67,8 @@ public TreeVisitor<?, ExecutionContext> getVisitor() {
                 new UsesMethod<>(JUNIT_ASSERT_FALSE_MATCHER),
                 new UsesMethod<>(JUNIT_ASSERT_MESSAGE_TRUE_MATCHER),
                 new UsesMethod<>(JUNIT_ASSERT_MESSAGE_FALSE_MATCHER),
+                new UsesMethod<>(TEST_NG_ASSERT_TRUE_MATCHER),
+                new UsesMethod<>(TEST_NG_ASSERT_FALSE_MATCHER),
                 new JavaIsoVisitor<ExecutionContext>() {
                     @Override
                     public J.Assert visitAssert(J.Assert _assert, ExecutionContext ctx) {
@@ -84,6 +90,8 @@ public J.Assert visitAssert(J.Assert _assert, ExecutionContext ctx) {
         matchers.put(JUNIT_ASSERT_FALSE_MATCHER, isFalse);
         matchers.put(JUNIT_ASSERT_MESSAGE_TRUE_MATCHER, args -> J.Literal.isLiteralValue(args.get(1), true));
         matchers.put(JUNIT_ASSERT_MESSAGE_FALSE_MATCHER, args -> J.Literal.isLiteralValue(args.get(1), false));
+        matchers.put(TEST_NG_ASSERT_TRUE_MATCHER, isTrue);
+        matchers.put(TEST_NG_ASSERT_FALSE_MATCHER, isFalse);
 
         return Preconditions.check(constraints, new JavaIsoVisitor<ExecutionContext>() {
             @Override