Apply OpenRewrite best practices to FindUnitTests

Author: timtebeek

src/main/java/org/openrewrite/java/testing/search/FindUnitTestTable.java

@@ -20,34 +20,33 @@
 import org.openrewrite.DataTable;
 import org.openrewrite.Recipe;
 
- public class FindUnitTestTable extends DataTable<FindUnitTestTable.Row> {
-     public FindUnitTestTable(Recipe recipe) {
-         super(recipe,
-                 "Methods in unit tests",
-                 "Method declarations used in unit tests");
-     }
-
-     @Value
-     public static class Row {
-         @Column(displayName = "Full method name",
-                 description = "The fully qualified name of the method declaration")
-         String fullyQualifiedMethodName;
-
-         @Column(displayName = "Method name",
-                 description = "The name of the method declaration")
-         String methodName;
-
-         @Column(displayName = "Method invocation",
-                 description = "How the method declaration is used as method invocation in a unit test.")
-         String methodInvocationExample;
-
-         @Column(displayName = "Name of test",
-                 description = "The name of the unit test where the method declaration is used.")
-         String nameOfTest;
-
-         @Column(displayName = "Location of test",
-                 description = "The location of the unit test where the method declaration is used.")
-         String locationOfTest;
-     }
- }
-
+public class FindUnitTestTable extends DataTable<FindUnitTestTable.Row> {
+    public FindUnitTestTable(Recipe recipe) {
+        super(recipe,
+                "Methods in unit tests",
+                "Method declarations used in unit tests");
+    }
+
+    @Value
+    public static class Row {
+        @Column(displayName = "Full method name",
+                description = "The fully qualified name of the method declaration")
+        String fullyQualifiedMethodName;
+
+        @Column(displayName = "Method name",
+                description = "The name of the method declaration")
+        String methodName;
+
+        @Column(displayName = "Method invocation",
+                description = "How the method declaration is used as method invocation in a unit test.")
+        String methodInvocationExample;
+
+        @Column(displayName = "Name of test",
+                description = "The name of the unit test where the method declaration is used.")
+        String nameOfTest;
+
+        @Column(displayName = "Location of test",
+                description = "The location of the unit test where the method declaration is used.")
+        String locationOfTest;
+    }
+}

src/main/java/org/openrewrite/java/testing/search/FindUnitTests.java

@@ -34,18 +34,11 @@
 
 public class FindUnitTests extends ScanningRecipe<FindUnitTests.Accumulator> {
 
-
-    private transient Accumulator acc = new Accumulator();
-
     transient FindUnitTestTable unitTestTable = new FindUnitTestTable(this);
 
     public FindUnitTests() {
     }
 
-    public FindUnitTests(Accumulator acc) {
-        this.acc = acc;
-    }
-
     @Override
     public String getDisplayName() {
         return "Find unit tests";
@@ -59,10 +52,6 @@ public String getDescription() {
     public static class Accumulator {
         private final Map<String, AccumulatorValue> unitTestsByKey = new HashMap<>();
 
-        public Map<String, AccumulatorValue> getUnitTestAndTheirMethods(){
-            return this.unitTestsByKey;
-        }
-
         public void addMethodInvocation(String clazz, String testName, String testBody, J.MethodInvocation invocation) {
             String key = clazz + "#" + testName;
             AccumulatorValue value = unitTestsByKey.get(key);
@@ -88,7 +77,6 @@ public static class AccumulatorValue {
 
     @Override
     public Accumulator getInitialValue(ExecutionContext ctx) {
-        if (acc != null) return acc;
         return new Accumulator();
     }