OpenRewrite recipe best practices (#825)

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.recipes.rewrite.OpenRewriteRecipeBestPractices?organizationId=QUxML09wZW4gU291cmNlL09wZW5SZXdyaXRl

Co-authored-by: Moderne <[email protected]>

Author: timtebeek

src/main/resources/META-INF/rewrite/examples.yml

@@ -308,40 +308,40 @@ examples:
 - description: ''
   sources:
   - before: |
-      import static org.testng.Assert.fail;
-
+      import static org.assertj.core.api.Assertions.assertThat;
       class Test {
           void test() {
-              fail("foo");
-              fail("foo", new IllegalStateException());
-              fail();
+              assertThat("test").isEqualTo("");
           }
       }
     after: |
-      import static org.assertj.core.api.Assertions.fail;
-
+      import static org.assertj.core.api.Assertions.assertThat;
       class Test {
           void test() {
-              fail("foo");
-              fail("foo", new IllegalStateException());
-              fail();
+              assertThat("test").isEmpty();
           }
       }
     language: java
 - description: ''
   sources:
   - before: |
-      import static org.assertj.core.api.Assertions.assertThat;
+      import static org.testng.Assert.fail;
+
       class Test {
           void test() {
-              assertThat("test").isEqualTo("");
+              fail("foo");
+              fail("foo", new IllegalStateException());
+              fail();
           }
       }
     after: |
-      import static org.assertj.core.api.Assertions.assertThat;
+      import static org.assertj.core.api.Assertions.fail;
+
       class Test {
           void test() {
-              assertThat("test").isEmpty();
+              fail("foo");
+              fail("foo", new IllegalStateException());
+              fail();
           }
       }
     language: java
@@ -3635,6 +3635,61 @@ examples:
 type: specs.openrewrite.org/v1beta/example
 recipeName: org.openrewrite.java.testing.mockito.Mockito1to3Migration
 examples:
+- description: ''
+  sources:
+  - before: |
+      package mockito.example;
+
+      import java.util.List;
+      import java.util.Map;
+      import java.util.Set;
+
+      import static org.mockito.ArgumentMatchers.anyListOf;
+      import static org.mockito.ArgumentMatchers.anySetOf;
+      import static org.mockito.ArgumentMatchers.anyMapOf;
+      import static org.mockito.Mockito.mock;
+      import static org.mockito.Mockito.when;
+
+      public class MockitoVarargMatcherTest {
+          public static class Foo {
+              public boolean addList(List<String> strings) { return true; }
+              public boolean addSet(Set<String> strings) { return true; }
+              public boolean addMap(Map<String, String> stringStringMap) { return true; }
+          }
+          public void usesVarargMatcher() {
+              Foo mockFoo = mock(Foo.class);
+              when(mockFoo.addList(anyListOf(String.class))).thenReturn(true);
+              when(mockFoo.addSet(anySetOf(String.class))).thenReturn(true);
+              when(mockFoo.addMap(anyMapOf(String.class, String.class))).thenReturn(true);
+          }
+      }
+    after: |
+      package mockito.example;
+
+      import java.util.List;
+      import java.util.Map;
+      import java.util.Set;
+
+      import static org.mockito.ArgumentMatchers.anyList;
+      import static org.mockito.ArgumentMatchers.anySet;
+      import static org.mockito.ArgumentMatchers.anyMap;
+      import static org.mockito.Mockito.mock;
+      import static org.mockito.Mockito.when;
+
+      public class MockitoVarargMatcherTest {
+          public static class Foo {
+              public boolean addList(List<String> strings) { return true; }
+              public boolean addSet(Set<String> strings) { return true; }
+              public boolean addMap(Map<String, String> stringStringMap) { return true; }
+          }
+          public void usesVarargMatcher() {
+              Foo mockFoo = mock(Foo.class);
+              when(mockFoo.addList(anyList())).thenReturn(true);
+              when(mockFoo.addSet(anySet())).thenReturn(true);
+              when(mockFoo.addMap(anyMap())).thenReturn(true);
+          }
+      }
+    language: java
 - description: ''
   sources:
   - before: |
@@ -3770,61 +3825,6 @@ examples:
       </project>
     path: pom.xml
     language: xml
-- description: ''
-  sources:
-  - before: |
-      package mockito.example;
-
-      import java.util.List;
-      import java.util.Map;
-      import java.util.Set;
-
-      import static org.mockito.ArgumentMatchers.anyListOf;
-      import static org.mockito.ArgumentMatchers.anySetOf;
-      import static org.mockito.ArgumentMatchers.anyMapOf;
-      import static org.mockito.Mockito.mock;
-      import static org.mockito.Mockito.when;
-
-      public class MockitoVarargMatcherTest {
-          public static class Foo {
-              public boolean addList(List<String> strings) { return true; }
-              public boolean addSet(Set<String> strings) { return true; }
-              public boolean addMap(Map<String, String> stringStringMap) { return true; }
-          }
-          public void usesVarargMatcher() {
-              Foo mockFoo = mock(Foo.class);
-              when(mockFoo.addList(anyListOf(String.class))).thenReturn(true);
-              when(mockFoo.addSet(anySetOf(String.class))).thenReturn(true);
-              when(mockFoo.addMap(anyMapOf(String.class, String.class))).thenReturn(true);
-          }
-      }
-    after: |
-      package mockito.example;
-
-      import java.util.List;
-      import java.util.Map;
-      import java.util.Set;
-
-      import static org.mockito.ArgumentMatchers.anyList;
-      import static org.mockito.ArgumentMatchers.anySet;
-      import static org.mockito.ArgumentMatchers.anyMap;
-      import static org.mockito.Mockito.mock;
-      import static org.mockito.Mockito.when;
-
-      public class MockitoVarargMatcherTest {
-          public static class Foo {
-              public boolean addList(List<String> strings) { return true; }
-              public boolean addSet(Set<String> strings) { return true; }
-              public boolean addMap(Map<String, String> stringStringMap) { return true; }
-          }
-          public void usesVarargMatcher() {
-              Foo mockFoo = mock(Foo.class);
-              when(mockFoo.addList(anyList())).thenReturn(true);
-              when(mockFoo.addSet(anySet())).thenReturn(true);
-              when(mockFoo.addMap(anyMap())).thenReturn(true);
-          }
-      }
-    language: java
 ---
 type: specs.openrewrite.org/v1beta/example
 recipeName: org.openrewrite.java.testing.mockito.Mockito1to4Migration
@@ -4403,23 +4403,17 @@ examples:
 
       class Test {
           void test() {
-              String actual = "hello";
-              assertThat(actual).isEqualTo("hello");
-              assertThat(actual).isNotEqualTo("world");
-              assertThat(actual).isNotNull();
-              assertThat(actual).contains("ell");
+              Exception e = new IllegalArgumentException("Invalid argument provided");
+              assertThat(e).hasMessageThat().contains("Invalid");
           }
       }
     after: |
       import static org.assertj.core.api.Assertions.assertThat;
 
       class Test {
           void test() {
-              String actual = "hello";
-              assertThat(actual).isEqualTo("hello");
-              assertThat(actual).isNotEqualTo("world");
-              assertThat(actual).isNotNull();
-              assertThat(actual).contains("ell");
+              Exception e = new IllegalArgumentException("Invalid argument provided");
+              assertThat(e).hasMessageContaining("Invalid");
           }
       }
     language: java
@@ -4430,17 +4424,23 @@ examples:
 
       class Test {
           void test() {
-              Exception e = new IllegalArgumentException("Invalid argument provided");
-              assertThat(e).hasMessageThat().contains("Invalid");
+              String actual = "hello";
+              assertThat(actual).isEqualTo("hello");
+              assertThat(actual).isNotEqualTo("world");
+              assertThat(actual).isNotNull();
+              assertThat(actual).contains("ell");
           }
       }
     after: |
       import static org.assertj.core.api.Assertions.assertThat;
 
       class Test {
           void test() {
-              Exception e = new IllegalArgumentException("Invalid argument provided");
-              assertThat(e).hasMessageContaining("Invalid");
+              String actual = "hello";
+              assertThat(actual).isEqualTo("hello");
+              assertThat(actual).isNotEqualTo("world");
+              assertThat(actual).isNotNull();
+              assertThat(actual).contains("ell");
           }
       }
     language: java