CleanupJUnitImports should exclude JUnit 4 from any dependencies that bring it in transitively. Closes #36

Author: sambsnyd

src/main/java/org/openrewrite/java/testing/junit5/CleanupJUnitImports.java

@@ -26,7 +26,6 @@
  * Orders imports and removes unused imports from classes which import symbols from the "org.junit" package.
  */
 public class CleanupJUnitImports extends Recipe {
-
     @Override
     protected TreeVisitor<?, ExecutionContext> getVisitor() {
         return new CleanupJUnitImportsVisitor();

src/main/resources/META-INF/rewrite/junit5.yml

@@ -29,6 +29,9 @@ recipeList:
   - org.openrewrite.maven.ExcludeDependency:
       groupId: org.junit.vintage
       artifactId: junit-vintage-engine
+  - org.openrewrite.maven.ExcludeDependency:
+      groupId: junit
+      artifactId: junit
   - org.openrewrite.java.testing.junit5.AssertToAssertions
   - org.openrewrite.java.testing.junit5.CategoryToTag
   - org.openrewrite.java.testing.junit5.CleanupJUnitImports

src/test/kotlin/org/openrewrite/java/testing/junit5/CleanupJUnitImportsTest.kt

@@ -16,7 +16,6 @@
 package org.openrewrite.java.testing.junit5
 
 import org.junit.jupiter.api.Test
-import org.openrewrite.Recipe
 import org.openrewrite.java.JavaRecipeTest
 import org.openrewrite.java.JavaParser
 
@@ -25,8 +24,7 @@ class CleanupJUnitImportsTest : JavaRecipeTest {
             .classpath("junit")
             .build()
 
-    override val recipe: Recipe
-        get() = CleanupJUnitImports()
+    override val recipe = CleanupJUnitImports()
 
     @Test
     fun removesUnusedImport() = assertChanged(

src/test/kotlin/org/openrewrite/java/testing/mockito/JunitMockitoUpgradeIntegrationTest.kt

@@ -476,6 +476,11 @@ class JunitMockitoUpgradeIntegrationTest : JavaRecipeTest {
                                 <version>4.12</version>
                                 <scope>test</scope>
                             </dependency>
+                            <dependency>
+                                <groupId>com.googlecode.json-simple</groupId>
+                                <artifactId>json-simple</artifactId>
+                                <version>1.1.1</version>
+                            </dependency>
                         </dependencies>
                     </project>
                 """.trimIndent())[0]
@@ -513,6 +518,17 @@ class JunitMockitoUpgradeIntegrationTest : JavaRecipeTest {
                         <version>5.7.1</version>
                         <scope>test</scope>
                     </dependency>
+                    <dependency>
+                        <groupId>com.googlecode.json-simple</groupId>
+                        <artifactId>json-simple</artifactId>
+                        <version>1.1.1</version>
+                        <exclusions>
+                            <exclusion>
+                                <groupId>junit</groupId>
+                                <artifactId>junit</artifactId>
+                            </exclusion>
+                        </exclusions>
+                    </dependency>
                 </dependencies>
             </project>
         """.trimIndent())