Comment out Maven visitors that do not currently compose well together

Author: sambsnyd

src/main/java/org/openrewrite/java/testing/junit5/TemporaryFolderToTempDir.java

@@ -252,7 +252,9 @@ public J.ClassDecl visitClassDecl(J.ClassDecl cd) {
     }
 
     /**
-     * Adds a method like this one to the target class:
+     * JUnit4 TemporaryFolder has a method called newFolder which returns a new folder located within a particular root directory.
+     * There is no direct JUnit5 analogue for TemporaryFolder or its newFolder method.
+     * This visitor adds a function called newFolder() to the test class it visits which provides the same functionality:
      *
      * private static File newFolder(File root, String ... folders) throws IOException {
      *     File result = new File(root, String.join("/", folders));

src/main/resources/META-INF/rewrite/junit5.yml

@@ -52,13 +52,30 @@ visitors:
   - org.openrewrite.maven.RemoveDependency:
       groupId: junit
       artifactId: junit
----
-type: specs.openrewrite.org/v1beta/visitor
-name: org.openrewrite.java.testing.junit5.ExcludeJUnitVintageEngine
-visitors:
-  - org.openrewrite.maven.ExcludeDependency:
-      groupId: org.junit.vintage
-      artifactId: junit-vintage-engine
+# Uncomment when a version of rewrite-maven has been published that has the fix for this issue:
+# https://github.com/openrewrite/rewrite/issues/92
+#---
+#type: specs.openrewrite.org/v1beta/visitor
+#name: org.openrewrite.java.testing.junit5.ExcludeJUnitVintageEngine
+#visitors:
+#  - org.openrewrite.maven.ExcludeDependency:
+#      groupId: org.junit.vintage
+#      artifactId: junit-vintage-engine
+#---
+#type: specs.openrewrite.org/v1beta/visitor
+#name: org.openrewrite.java.testing.junit5.AddJunit5Dependency
+#visitors:
+#  - org.openrewrite.maven.AddDependency:
+#      groupId: org.junit.jupiter
+#      artifactId: junit-jupiter-api
+#      version: 5.7.0
+#      scope: test
+#      skipIfPresent: true
+#  - org.openrewrite.maven.AddDependency:
+#      groupId: org.junit.jupiter
+#      artifactId: junit-jupiter-engine
+#      version: 5.x
+#      scope: test
 ---
 type: specs.openrewrite.org/v1beta/recipe
 name: org.openrewrite.java.testing.JUnit5Migration

src/test/kotlin/org/openrewrite/java/testing/mockito/JunitMockitoUpgradeIntegrationTest.kt

@@ -15,11 +15,13 @@
  */
 package org.openrewrite.java.testing.mockito
 
+import org.junit.jupiter.api.Assertions.assertEquals
+import org.junit.jupiter.api.Disabled
 import org.junit.jupiter.api.Test
 import org.openrewrite.*
 import org.openrewrite.java.JavaParser
-import org.openrewrite.java.OrderImports
 import org.openrewrite.java.tree.J
+import org.openrewrite.maven.MavenParser
 
 /**
  * Validates the recipes related to upgrading from Mockito 1 to Mockito 3
@@ -454,4 +456,94 @@ class JunitMockitoUpgradeIntegrationTest : RefactorVisitorTestForParser<J.Compil
                 }
             """
     )
+
+    @Disabled("https://github.com/openrewrite/rewrite/issues/92")
+    @Test
+    fun upgradesPom() {
+        val pom = MavenParser.builder().build().parse("""
+            <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+                <modelVersion>4.0.0</modelVersion>
+            
+                <groupId>org.openrewrite.example</groupId>
+                <artifactId>integration-testing</artifactId>
+                <version>1.0</version>
+                <name>integration-testing</name>
+            
+                <properties>
+                    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+                    <java.version>1.8</java.version>
+                </properties>
+            
+                <dependencies>
+                    <dependency>
+                        <groupId>junit</groupId>
+                        <artifactId>junit</artifactId>
+                        <version>4.12</version>
+                        <scope>test</scope>
+                    </dependency>
+                </dependencies>
+            
+                <build>
+                    <plugins>
+                        <plugin>
+                            <groupId>org.apache.maven.plugins</groupId>
+                            <artifactId>maven-surefire-plugin</artifactId>
+                            <version>3.0.0-M5</version>
+                        </plugin>
+                    </plugins>
+                </build>
+            </project>
+        """.trimIndent())
+
+        val fixed = Refactor(true)
+                .visit(visitors)
+                .fix(pom)
+                .first()
+                .fixed!!
+                .printTrimmed()
+
+        val expected = """
+            <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+                <modelVersion>4.0.0</modelVersion>
+            
+                <groupId>org.openrewrite.example</groupId>
+                <artifactId>integration-testing</artifactId>
+                <version>1.0</version>
+                <name>integration-testing</name>
+            
+                <properties>
+                    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+                    <java.version>1.8</java.version>
+                </properties>
+            
+                <dependencies>
+                    <dependency>
+                        <groupId>org.junit.jupiter</groupId>
+                        <artifactId>junit-jupiter-api</artifactId>
+                        <version>5.7.0</version>
+                        <scope>test</scope>
+                    </dependency>
+                    <dependency>
+                        <groupId>org.junit.jupiter</groupId>
+                        <artifactId>junit-jupiter-engine</artifactId>
+                        <version>5.7.0</version>
+                        <scope>test</scope>
+                    </dependency>
+                </dependencies>
+            
+                <build>
+                    <plugins>
+                        <plugin>
+                            <groupId>org.apache.maven.plugins</groupId>
+                            <artifactId>maven-surefire-plugin</artifactId>
+                            <version>3.0.0-M5</version>
+                        </plugin>
+                    </plugins>
+                </build>
+            </project>
+        """.trimIndent()
+
+        assertEquals(expected, fixed)
+    }
+
 }