Commit 430f635
authored
removing UpgradeOkHttpMockWebServer from JUnit5 upgrade. mockwebserver3-junit5 is not necessary for JUnit5 compatibility; only to provide the relevant Extension. And given that the corresponding JUnit4 Rule seems to have been introduced in the same okhttp version (5.x), it is unlikely for existing apps on JUnit4 to have usages non-JUnit-5-compatible code (and even if they do use the MockWebServerRule, this recipe does not yet convert that to MockWebServerExtension anyway). there's also a version management concern here; moving to an "alpha" version of a dep may surprise/confuse users, and, moving *only* mockwebserver to that version (without touching other okhttp deps) may risk compatibility issues (#456)
1 parent 430174a commit 430f635
1 file changed
+1
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
91 | | - | |
92 | 91 | | |
93 | 92 | | |
94 | 93 | | |
| |||
243 | 242 | | |
244 | 243 | | |
245 | 244 | | |
246 | | - | |
| 245 | + | |
247 | 246 | | |
248 | 247 | | |
249 | 248 | | |
| |||
0 commit comments