Skip to content

Commit 430f635

Browse files
authored
removing UpgradeOkHttpMockWebServer from JUnit5 upgrade. mockwebserver3-junit5 is not necessary for JUnit5 compatibility; only to provide the relevant Extension. And given that the corresponding JUnit4 Rule seems to have been introduced in the same okhttp version (5.x), it is unlikely for existing apps on JUnit4 to have usages non-JUnit-5-compatible code (and even if they do use the MockWebServerRule, this recipe does not yet convert that to MockWebServerExtension anyway). there's also a version management concern here; moving to an "alpha" version of a dep may surprise/confuse users, and, moving *only* mockwebserver to that version (without touching other okhttp deps) may risk compatibility issues (#456)
1 parent 430174a commit 430f635

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

src/main/resources/META-INF/rewrite/junit5.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ recipeList:
8888
- org.openrewrite.java.testing.junit5.EnclosedToNested
8989
- org.openrewrite.java.testing.junit5.AddMissingNested
9090
- org.openrewrite.java.testing.hamcrest.AddHamcrestIfUsed
91-
- org.openrewrite.java.testing.junit5.UpgradeOkHttpMockWebServer
9291
- org.openrewrite.java.testing.junit5.UseXMLUnitLegacy
9392
- org.openrewrite.java.dependencies.RemoveDependency:
9493
groupId: junit
@@ -243,7 +242,7 @@ recipeList:
243242
type: specs.openrewrite.org/v1beta/recipe
244243
name: org.openrewrite.java.testing.junit5.UpgradeOkHttpMockWebServer
245244
displayName: Use OkHttp 3 MockWebServer for JUnit 5
246-
description: Migrates OkHttp 3 `MockWebServer` to the JUnit Jupiter compatible version.
245+
description: Migrates OkHttp 3 `MockWebServer` to enable JUnit Jupiter Extension support
247246
tags:
248247
- testing
249248
- junit

0 commit comments

Comments
 (0)