Skip to content

Commit 4766863

Browse files
committed
Prepare for new version of rewrite core that will fix issues with OrderImports
1 parent bda8530 commit 4766863

File tree

5 files changed

+30
-15
lines changed

5 files changed

+30
-15
lines changed

src/before/java/org/openrewrite/java/testing/junit5/ExampleJunitTestClass.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,4 +100,10 @@ public void lambdaThrow() {
100100

101101
@Test(timeout = 500)
102102
public void bar() { }
103+
104+
@Test
105+
public void aTest() {
106+
String foo = mock(String.class);
107+
when(foo.concat(any())).then(invocation -> invocation.getArgumentAt(0, String.class));
108+
}
103109
}

src/main/resources/META-INF/rewrite/junit5.yml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,14 @@ visitors:
3939
- org.openrewrite.java.ChangeType:
4040
type: org.junit.Assume
4141
targetType: org.junit.jupiter.api.Assumptions
42-
---
43-
type: specs.openrewrite.org/v1beta/visitor
44-
name: org.openrewrite.java.testing.junit5.RemoveUnusedImports
45-
visitors:
46-
- org.openrewrite.java.OrderImports:
47-
removeUnused: true
42+
# Uncomment once a version of rewrite core libs has been published containing this commit:
43+
# https://github.com/openrewrite/rewrite/commit/8fe84fa49e6233882014d08e99c5793d5e02b36a
44+
#---
45+
#type: specs.openrewrite.org/v1beta/visitor
46+
#name: org.openrewrite.java.testing.junit5.RemoveUnusedImports
47+
#visitors:
48+
# - org.openrewrite.java.OrderImports:
49+
# removeUnused: true
4850
---
4951
type: specs.openrewrite.org/v1beta/recipe
5052
name: org.openrewrite.java.testing.JUnit5Migration

src/main/resources/META-INF/rewrite/mockito.yml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,14 @@ visitors:
4444
- org.openrewrite.java.ChangeType:
4545
type: org.mockito.runners.MockitoJUnitRunner
4646
targetType: org.mockito.junit.MockitoJUnitRunner
47-
---
48-
type: specs.openrewrite.org/v1beta/visitor
49-
name: org.openrewrite.java.testing.mockito.RemoveUnusedImports
50-
visitors:
51-
- org.openrewrite.java.OrderImports:
52-
removeUnused: true
47+
# Uncomment once a version of rewrite core libs has been published containing this commit:
48+
# https://github.com/openrewrite/rewrite/commit/8fe84fa49e6233882014d08e99c5793d5e02b36a
49+
#---
50+
#type: specs.openrewrite.org/v1beta/visitor
51+
#name: org.openrewrite.java.testing.mockito.RemoveUnusedImports
52+
#visitors:
53+
# - org.openrewrite.java.OrderImports:
54+
# removeUnused: true
5355
---
5456
type: specs.openrewrite.org/v1beta/recipe
5557
name: org.openrewrite.java.testing.Mockito1to3Migration

src/test/kotlin/org/openrewrite/java/testing/BeforeToAfter.kt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ package org.openrewrite.java.testing
1818
import org.openrewrite.Refactor
1919
import org.openrewrite.loadVisitorsForTest
2020
import org.openrewrite.java.JavaParser
21+
import org.openrewrite.java.OrderImports
2122
import java.nio.file.Files
2223
import java.nio.file.Path
2324
import java.nio.file.Paths
@@ -30,7 +31,11 @@ fun main(args: Array<String>) {
3031
.classpath("mockito-all", "junit")
3132
.build()
3233

33-
val visitors = loadVisitorsForTest("org.openrewrite.java.testing.JUnit5Migration", "org.openrewrite.java.testing.Mockito1to3Migration")
34+
val visitors = loadVisitorsForTest(
35+
"org.openrewrite.java.testing.JUnit5Migration",
36+
"org.openrewrite.java.testing.Mockito1to3Migration"
37+
)
38+
3439
val sources = parser.parse(listJavaSources(beforeDir), beforeDir)
3540
val changes = Refactor(true)
3641
.visit(visitors)

src/test/kotlin/org/openrewrite/java/testing/mockito/JunitMockitoUpgradeIntegrationTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ class JunitMockitoUpgradeIntegrationTest : RefactorVisitorTestForParser<J.Compil
2828
override val parser: JavaParser = JavaParser.fromJavaVersion()
2929
.classpath("mockito-all", "junit")
3030
.build()
31-
override val visitors: Iterable<RefactorVisitor<*>> = //loadVisitorsForTest("org.openrewrite.java.testing.JUnit5Migration", "org.openrewrite.java.testing.Mockito1to3Migration")
32-
listOf(OrderImports().apply { setRemoveUnused(true) })
31+
override val visitors: Iterable<RefactorVisitor<*>> = loadVisitorsForTest("org.openrewrite.java.testing.JUnit5Migration", "org.openrewrite.java.testing.Mockito1to3Migration")
32+
3333
/**
3434
* Replace org.mockito.MockitoAnnotations.Mock with org.mockito.Mock
3535
*/

0 commit comments

Comments
 (0)