refactor: Use method references in lambda

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.ReplaceLambdaWithMethodReference?organizationId=T3BlblJld3JpdGU%3D

Co-authored-by: Moderne <[email protected]>

Author: timtebeek

src/main/java/org/openrewrite/java/testing/cleanup/TestsShouldIncludeAssertions.java

@@ -165,7 +165,7 @@ public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, Atomi
         }
 
         private boolean methodInvocationInBodyContainsAssertion() {
-            J.ClassDeclaration classDeclaration = getCursor().dropParentUntil(is -> is instanceof J.ClassDeclaration).getValue();
+            J.ClassDeclaration classDeclaration = getCursor().dropParentUntil(org.openrewrite.java.tree.J.ClassDeclaration.class::isInstance).getValue();
 
             JavaIsoVisitor<Set<MethodMatcher>> findMethodDeclarationsVisitor = new JavaIsoVisitor<Set<MethodMatcher>>() {
                 @Override

src/main/java/org/openrewrite/java/testing/cleanup/TestsShouldNotBePublic.java

@@ -87,18 +87,18 @@ public ClassDeclaration visitClassDeclaration(ClassDeclaration classDecl, Execut
                     && c.getModifiers().stream().noneMatch(mod -> mod.getType() == Type.Abstract)) {
 
                 boolean hasTestMethods = c.getBody().getStatements().stream()
-                        .filter(statement -> statement instanceof J.MethodDeclaration)
+                        .filter(org.openrewrite.java.tree.J.MethodDeclaration.class::isInstance)
                         .map(J.MethodDeclaration.class::cast)
                         .anyMatch(this::hasJUnit5MethodAnnotation);
 
                 boolean hasPublicNonTestMethods = c.getBody().getStatements().stream()
-                        .filter(statement -> statement instanceof J.MethodDeclaration)
+                        .filter(org.openrewrite.java.tree.J.MethodDeclaration.class::isInstance)
                         .map(J.MethodDeclaration.class::cast)
                         .filter(m -> m.getModifiers().stream().anyMatch(mod -> mod.getType() == J.Modifier.Type.Public))
                         .anyMatch(method -> !hasJUnit5MethodAnnotation(method));
 
                 boolean hasPublicVariableDeclarations = c.getBody().getStatements().stream()
-                        .filter(statement -> statement instanceof J.VariableDeclarations)
+                        .filter(org.openrewrite.java.tree.J.VariableDeclarations.class::isInstance)
                         .map(J.VariableDeclarations.class::cast)
                         .anyMatch(m -> m.getModifiers().stream().anyMatch(mod -> mod.getType() == J.Modifier.Type.Public));
 

src/main/java/org/openrewrite/java/testing/junit5/ParameterizedRunnerToParameterized.java

@@ -71,7 +71,7 @@ public J.ClassDeclaration visitClassDeclaration(J.ClassDeclaration classDecl, Ex
                 String initMethodName = "init" + cd.getSimpleName();
 
                 // Constructor Injected Test
-                if (parametersMethodName != null && constructorParams != null && constructorParams.stream().anyMatch(p -> p instanceof J.VariableDeclarations)) {
+                if (parametersMethodName != null && constructorParams != null && constructorParams.stream().anyMatch(org.openrewrite.java.tree.J.VariableDeclarations.class::isInstance)) {
                     doAfterVisit(new ParameterizedRunnerToParameterizedTestsVisitor(classDecl, parametersMethodName, initMethodName, parametersAnnotationArguments, constructorParams, true, ctx));
                 }