groupId and artifactId on project POM definition need to be resolved fully to prevent being interpreted as an external POM (#6477)

* Add test to reproduce the issue

* Resolve `groupId` and `artifactId` on project POMs as well

Author: shanman190

rewrite-maven/src/main/java/org/openrewrite/maven/internal/MavenPomDownloader.java

@@ -176,8 +176,8 @@ private Map<GroupArtifactVersion, Pom> projectPomsByGav(Map<Path, Pom> projectPo
             List<Pom> ancestryWithinProject = getAncestryWithinProject(projectPom, projectPoms);
             Map<String, String> mergedProperties = mergeProperties(ancestryWithinProject);
             GroupArtifactVersion gav = new GroupArtifactVersion(
-                    projectPom.getGroupId(),
-                    projectPom.getArtifactId(),
+                    ResolvedPom.placeholderHelper.replacePlaceholders(projectPom.getGroupId(), mergedProperties::get),
+                    ResolvedPom.placeholderHelper.replacePlaceholders(projectPom.getArtifactId(), mergedProperties::get),
                     ResolvedPom.placeholderHelper.replacePlaceholders(projectPom.getVersion(), mergedProperties::get)
             );
             result.put(gav, projectPom);

rewrite-maven/src/test/java/org/openrewrite/maven/MavenParserTest.java

@@ -39,6 +39,7 @@
 import org.openrewrite.maven.internal.MavenParsingException;
 import org.openrewrite.maven.tree.*;
 import org.openrewrite.test.RewriteTest;
+import org.openrewrite.test.SourceSpecs;
 import org.openrewrite.test.TypeValidation;
 import org.openrewrite.tree.ParseError;
 
@@ -51,6 +52,7 @@
 import static org.assertj.core.api.Assertions.*;
 import static org.openrewrite.java.Assertions.mavenProject;
 import static org.openrewrite.maven.Assertions.pomXml;
+import static org.openrewrite.test.SourceSpecs.dir;
 
 class MavenParserTest implements RewriteTest {
 
@@ -4810,4 +4812,86 @@ void transitiveDependencyVersion() {
           )
         );
     }
+
+    @Test
+    void groupIdAndArtifactIdAsProperties() {
+        rewriteRun(
+          mavenProject("my-app",
+            pomXml("""
+              <project>
+                <groupId>com.example</groupId>
+                <artifactId>parent</artifactId>
+                <version>1</version>
+                <packaging>pom</packaging>
+                <properties>
+                  <my-app.child-a.groupId>com.example</my-app.child-a.groupId>
+                  <my-app.child-a.artifactId>child-a</my-app.child-a.artifactId>
+                </properties>
+                <modules>
+                  <module>child-a</module>
+                  <module>child-b</module>
+                </modules>
+              </project>
+              """
+            ),
+            dir("child-a",
+              pomXml(
+                """
+                  <project>
+                    <groupId>${my-app.child-a.groupId}</groupId>
+                    <artifactId>${my-app.child-a.artifactId}</artifactId>
+                    <version>1</version>
+                    <parent>
+                      <groupId>com.example</groupId>
+                      <artifactId>parent</artifactId>
+                      <version>1</version>
+                    </parent>
+                    <dependencies>
+                      <dependency>
+                        <groupId>org.springframework</groupId>
+                        <artifactId>spring-core</artifactId>
+                        <version>6.2.15</version>
+                      </dependency>
+                    </dependencies>
+                  </project>
+                  """
+              )
+            ),
+            dir("child-b",
+              pomXml(
+                """
+                  <project>
+                    <groupId>com.example</groupId>
+                    <artifactId>child-b</artifactId>
+                    <version>1</version>
+                    <parent>
+                      <groupId>com.example</groupId>
+                      <artifactId>parent</artifactId>
+                      <version>1</version>
+                    </parent>
+                    <dependencies>
+                      <dependency>
+                        <groupId>${my-app.child-a.groupId}</groupId>
+                        <artifactId>${my-app.child-a.artifactId}</artifactId>
+                        <version>1</version>
+                      </dependency>
+                    </dependencies>
+                  </project>
+                  """,
+                spec -> spec.afterRecipe(pom -> {
+                    assertThat(pom).isNotNull();
+                    Optional<MavenResolutionResult> maybeMrr = pom.getMarkers().findFirst(MavenResolutionResult.class);
+                    assertThat(maybeMrr).isPresent();
+
+                    MavenResolutionResult mrr = maybeMrr.get();
+                    assertThat(mrr.getDependencies().get(Scope.Compile).stream())
+                      .anyMatch(resolvedDependency -> "org.springframework".equals(resolvedDependency.getGroupId()) &&
+                        "spring-core".equals(resolvedDependency.getArtifactId()) &&
+                        "6.2.15".equals(resolvedDependency.getVersion()));
+                })
+              )
+            )
+          )
+        );
+    }
 }