Update version in the Gradle model (#6428)

* Update version in the Gradle model

* Slight polish

---------

Co-authored-by: Tim te Beek <[email protected]>

Author: BoykoAlex

rewrite-gradle/src/main/java/org/openrewrite/gradle/ChangeDependency.java

@@ -192,7 +192,7 @@ public boolean isAcceptable(SourceFile sourceFile, ExecutionContext ctx) {
 
                     sourceFile = (JavaSourceFile) super.visit(sourceFile, ctx);
                     if (sourceFile != null && sourceFile != tree) {
-                        sourceFile = sourceFile.withMarkers(sourceFile.getMarkers().setByType(updateGradleModel(gradleProject)));
+                        sourceFile = sourceFile.withMarkers(sourceFile.getMarkers().setByType(updateGradleModel(gradleProject, ctx)));
                         if (changeManagedDependency == null || changeManagedDependency) {
                             doAfterVisit(new ChangeManagedDependency(oldGroupId, oldArtifactId, newGroupId, newArtifactId, newVersion, versionPattern).getVisitor());
                         }
@@ -626,7 +626,7 @@ private J.MethodInvocation updateDependency(J.MethodInvocation m, ExecutionConte
                 return m;
             }
 
-            private GradleProject updateGradleModel(GradleProject gp) {
+            private GradleProject updateGradleModel(GradleProject gp, ExecutionContext ctx) {
                 Map<String, GradleDependencyConfiguration> nameToConfiguration = gp.getNameToConfiguration();
                 Map<String, GradleDependencyConfiguration> newNameToConfiguration = new HashMap<>(nameToConfiguration.size());
                 boolean anyChanged = false;
@@ -642,6 +642,17 @@ private GradleProject updateGradleModel(GradleProject gp) {
                                 if (newArtifactId != null) {
                                     gav = gav.withArtifactId(newArtifactId);
                                 }
+                                if (!StringUtils.isBlank(newVersion) && (!StringUtils.isBlank(gav.getVersion()) || Boolean.TRUE.equals(overrideManagedVersion))) {
+                                    try {
+                                        String resolvedVersion = new DependencyVersionSelector(metadataFailures, gradleProject, null)
+                                                .select(new GroupArtifact(gav.getGroupId(), gav.getArtifactId()), gdc.getName(), newVersion, versionPattern, ctx);
+                                        if (resolvedVersion != null && !resolvedVersion.equals(gav.getVersion())) {
+                                            gav = gav.withVersion(resolvedVersion);
+                                        }
+                                    } catch (MavenDownloadingException e) {
+                                        // Failure already in `metadataFailures`
+                                    }
+                                }
                                 if (gav != r.getGav()) {
                                     r = r.withGav(gav);
                                 }
@@ -661,6 +672,17 @@ private GradleProject updateGradleModel(GradleProject gp) {
                                 if (newArtifactId != null) {
                                     gav = gav.withArtifactId(newArtifactId);
                                 }
+                                if (!StringUtils.isBlank(newVersion) && (!StringUtils.isBlank(gav.getVersion()) || Boolean.TRUE.equals(overrideManagedVersion))) {
+                                    try {
+                                        String resolvedVersion = new DependencyVersionSelector(metadataFailures, gradleProject, null)
+                                                .select(new GroupArtifact(gav.getGroupId(), gav.getArtifactId()), gdc.getName(), newVersion, versionPattern, ctx);
+                                        if (resolvedVersion != null && !resolvedVersion.equals(gav.getVersion())) {
+                                            gav = gav.withVersion(resolvedVersion);
+                                        }
+                                    } catch (MavenDownloadingException e) {
+                                        // Failure already in `metadataFailures`
+                                    }
+                                }
                                 if (gav != r.getGav()) {
                                     r = r.withGav(gav);
                                 }

rewrite-gradle/src/test/java/org/openrewrite/gradle/ChangeDependencyTest.java

@@ -20,6 +20,7 @@
 import org.openrewrite.test.RecipeSpec;
 import org.openrewrite.test.RewriteTest;
 
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.openrewrite.gradle.Assertions.buildGradle;
 import static org.openrewrite.gradle.Assertions.buildGradleKts;
 import static org.openrewrite.gradle.toolingapi.Assertions.withToolingApi;
@@ -799,4 +800,53 @@ void makeChangesInKotlinDependencyManagementImports() {
           )
         );
     }
+
+    @Test
+    void noDuplicateJacksonDatabindDependenciesInGradle() {
+        rewriteRun(
+          spec -> spec.beforeRecipe(withToolingApi())
+            .recipes(
+              new ChangeDependency(
+                "com.fasterxml.jackson.core",
+                "jackson-databind",
+                "tools.jackson.core",
+                null,
+                "3.0.x",
+                null,
+                null,
+                null
+              ),
+              new ChangeDependency(
+                "com.fasterxml.jackson.datatype",
+                "jackson-datatype-jsr310",
+                "tools.jackson.core",
+                "jackson-databind",
+                "3.0.x",
+                null,
+                null,
+                null
+              )
+            ),
+          buildGradle(
+            //language=gradle
+            """
+              plugins {
+                  id("java-library")
+              }
+              repositories {
+                  mavenCentral()
+              }
+              dependencies {
+                  implementation("com.fasterxml.jackson.core:jackson-databind:2.19.0")
+                  implementation("com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.19.0")
+              }
+              """,
+            spec -> spec.after(buildGradle ->
+              assertThat(buildGradle)
+                .containsOnlyOnce("tools.jackson.core:jackson-databind:3")
+                .doesNotContain("datatype")
+                .actual())
+          )
+        );
+    }
 }