Fix unchanged Quark files appearing in changeset results (#7130)

* Fix unchanged Quark and Binary files appearing in changeset results

Quark.printAll() and Binary.printAll() throw UnsupportedOperationException,
causing Result.isLocalAndHasNoChanges() to incorrectly report them as
changed. Add explicit handling for these types before calling printAll().

Fixes #3948

* Add test for Quark replaced by Remote (wrapper update scenario)

* Remove binary file comparison from Result

Removed binary file comparison logic from Result class.

Author: timtebeek

rewrite-core/src/main/java/org/openrewrite/Result.java

@@ -23,6 +23,8 @@
 import org.openrewrite.marker.DeserializationError;
 import org.openrewrite.marker.RecipesThatMadeChanges;
 import org.openrewrite.marker.SearchResult;
+import org.openrewrite.binary.Binary;
+import org.openrewrite.quark.Quark;
 import org.openrewrite.remote.Remote;
 
 import java.nio.file.Path;
@@ -268,11 +270,21 @@ public String toString() {
 
     public static boolean isLocalAndHasNoChanges(@Nullable SourceFile before, @Nullable SourceFile after) {
         try {
-            return (before == after) ||
-                   (before != null && after != null &&
-                    // Remote source files are fetched on `printAll`, let's avoid that cost.
-                    !(before instanceof Remote) && !(after instanceof Remote) &&
-                    before.printAll().equals(after.printAll()));
+            if (before == after) {
+                return true;
+            }
+            if (before == null || after == null) {
+                return false;
+            }
+            // Remote source files are fetched on `printAll`, let's avoid that cost.
+            if (before instanceof Remote || after instanceof Remote) {
+                return false;
+            }
+            // Quarks don't support printAll(); compare by source path instead
+            if (before instanceof Quark && after instanceof Quark) {
+                return before.getSourcePath().equals(after.getSourcePath());
+            }
+            return before.printAll().equals(after.printAll());
         } catch (Exception e) {
             return false;
         }

rewrite-core/src/test/java/org/openrewrite/quark/QuarkTest.java

@@ -18,15 +18,45 @@
 import org.jspecify.annotations.Nullable;
 import org.junit.jupiter.api.Test;
 import org.openrewrite.*;
+import org.openrewrite.marker.Markers;
 import org.openrewrite.marker.SearchResult;
+import org.openrewrite.remote.Remote;
 import org.openrewrite.test.RewriteTest;
 
+import java.net.URI;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.UUID;
+
 import static java.util.Objects.requireNonNull;
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.openrewrite.test.RewriteTest.toRecipe;
 import static org.openrewrite.test.SourceSpecs.other;
 
 class QuarkTest implements RewriteTest {
 
+    @Test
+    void unchangedQuarkHasNoChanges() {
+        Quark before = new Quark(UUID.randomUUID(), Paths.get("file.jks"), Markers.EMPTY, null, null);
+        Quark after = new Quark(UUID.randomUUID(), Paths.get("file.jks"), Markers.EMPTY, null, null);
+        assertThat(Result.isLocalAndHasNoChanges(before, after)).isTrue();
+    }
+
+    @Test
+    void quarkWithDifferentPathHasChanges() {
+        Quark before = new Quark(UUID.randomUUID(), Paths.get("old.jks"), Markers.EMPTY, null, null);
+        Quark after = new Quark(UUID.randomUUID(), Paths.get("new.jks"), Markers.EMPTY, null, null);
+        assertThat(Result.isLocalAndHasNoChanges(before, after)).isFalse();
+    }
+
+    @Test
+    void quarkReplacedByRemoteHasChanges() {
+        Path path = Paths.get(".mvn/wrapper/maven-wrapper.jar");
+        Quark before = new Quark(UUID.randomUUID(), path, Markers.EMPTY, null, null);
+        Remote after = Remote.builder(before).build(URI.create("https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.3.2/maven-wrapper-3.3.2.jar"));
+        assertThat(Result.isLocalAndHasNoChanges(before, after)).isFalse();
+    }
+
     @DocumentExample
     @Test
     void renderMarkersOnQuarks() {