Gracefully handle malformed Maven version strings (#7234)

* Gracefully handle malformed Maven version strings

Fix NumberFormatException when encountering malformed version strings
like `-captain-daily-SNAPSHOT` in Maven repository metadata.

Fixes #7233

* Remove VersionTest (covered by VersionRequirementTest)

Author: timtebeek

rewrite-maven/src/main/java/org/openrewrite/maven/internal/VersionRequirement.java

@@ -258,7 +258,12 @@ public String toString() {
         VersionSpec hardRequirement = nearestHardRequirement.versionSpec;
         Version latest = null;
         for (String availableVersion : availableVersions.call()) {
-            Version version = new Version(availableVersion);
+            Version version;
+            try {
+                version = new Version(availableVersion);
+            } catch (IllegalArgumentException e) {
+                continue;
+            }
 
             if ((hardRequirement instanceof DynamicVersion && ((DynamicVersion) hardRequirement).matches(version)) ||
                 (hardRequirement instanceof RangeSet && ((RangeSet) hardRequirement).matches(version))) {

rewrite-maven/src/main/java/org/openrewrite/maven/tree/Version.java

@@ -275,7 +275,7 @@ public boolean next() {
                 } else {
                     this.tokenStart = 0;
                     this.tokenEnd = 1;
-                    this.number = true;
+                    this.number = false;
                 }
 
                 return true;

rewrite-maven/src/test/java/org/openrewrite/maven/internal/VersionRequirementTest.java

@@ -26,6 +26,10 @@ private Iterable<String> available() {
         return List.of("1", "2", "3", "4", "5", "6", "7", "8", "9", "10");
     }
 
+    private Iterable<String> availableWithMalformed() {
+        return List.of("1", "-captain-daily-SNAPSHOT", "2", "3");
+    }
+
     @Test
     void rangeSet() throws Exception {
         assertThat(VersionRequirement.fromVersion("[1,11)", 0).resolve(this::available))
@@ -64,4 +68,10 @@ void emptyUnboundedRange() throws Exception {
         assertThat(VersionRequirement.fromVersion("(,)", 0).resolve(this::available))
                 .isEqualTo("10");
     }
+
+    @Test
+    void malformedVersionsAreSkipped() throws Exception {
+        assertThat(VersionRequirement.fromVersion("[1,4)", 0).resolve(this::availableWithMalformed))
+                .isEqualTo("3");
+    }
 }