Fix AddDependency duplicating dependencies in applied scripts (#6650)

* Fix AddDependency duplicating dependencies in applied scripts

* Move match constraint to `IsBuildGradle`

---------

Co-authored-by: Tim te Beek <tim@moderne.io>

Author: AnastasiiaDesiateryk

rewrite-gradle/src/main/java/org/openrewrite/gradle/AddDependency.java

@@ -188,7 +188,7 @@ public TreeVisitor<?, ExecutionContext> getVisitor(Scanned acc) {
         // or when source files were scanned
         boolean hasExplicitConfiguration = !StringUtils.isBlank(configuration);
         return Preconditions.check(hasExplicitConfiguration || onlyIfUsing == null || !acc.configurationsByProject.isEmpty(),
-                Preconditions.check(new IsBuildGradle<>(), new JavaIsoVisitor<ExecutionContext>() {
+                Preconditions.check(new IsBuildGradle<>(true), new JavaIsoVisitor<ExecutionContext>() {
 
                     @Override
                     public @Nullable J visit(@Nullable Tree tree, ExecutionContext ctx) {

rewrite-gradle/src/main/java/org/openrewrite/gradle/GradleConfigurationFilter.java

@@ -36,7 +36,7 @@ class GradleConfigurationFilter {
     public void removeTransitiveConfigurations() {
         Set<String> tmpConfigurations = new HashSet<>(filteredConfigurations);
         for (String tmpConfiguration : tmpConfigurations) {
-            GradleDependencyConfiguration gdc = requireNonNull((gradleProject.getConfiguration(tmpConfiguration)));
+            GradleDependencyConfiguration gdc = requireNonNull(gradleProject.getConfiguration(tmpConfiguration));
             for (GradleDependencyConfiguration transitive : gradleProject.configurationsExtendingFrom(gdc, true)) {
                 filteredConfigurations.remove(transitive.getName());
             }

rewrite-gradle/src/main/java/org/openrewrite/gradle/IsBuildGradle.java

@@ -24,13 +24,35 @@
 
 import java.nio.file.Path;
 
+/**
+ * Finds Gradle build files ending in `.gradle` and `.gradle.kts` files, but not `settings.gradle` or `settings.gradle.kts` files.
+ * @param <P>
+ */
 public class IsBuildGradle<P> extends TreeVisitor<Tree, P> {
+
+    /**
+     * Only match `build.gradle` and `build.gradle.kts` files, not any `dependencies.gradle` or similar files.
+     */
+    boolean exactMatch;
+
+    public IsBuildGradle() {
+        this(false);
+    }
+
+    public IsBuildGradle(boolean exactMatch) {
+        this.exactMatch = exactMatch;
+    }
+
     @Override
     public @Nullable Tree preVisit(@NonNull Tree tree, P p) {
         stopAfterPreVisit();
         if (tree instanceof JavaSourceFile) {
             JavaSourceFile sourceFile = (JavaSourceFile) tree;
-            if (matches(sourceFile.getSourcePath())) {
+            Path sourcePath = sourceFile.getSourcePath();
+            if (exactMatch) {
+                return sourcePath.endsWith("build.gradle") || sourcePath.endsWith("build.gradle.kts") ? SearchResult.found(sourceFile) : tree;
+            }
+            if (matches(sourcePath)) {
                 return SearchResult.found(sourceFile);
             }
         }

rewrite-gradle/src/test/java/org/openrewrite/gradle/AddDependencyTest.java

@@ -1872,6 +1872,54 @@ fun githubPackages(): Pair<String, String> {
         );
     }
 
+    @Test
+    void doNotAddDependencyToAppliedScripts() {
+        rewriteRun(
+          spec -> spec.recipe(addDependency("com.google.guava:guava:29.0-jre", null, "implementation")),
+          mavenProject("project",
+            buildGradle(
+              //language=groovy
+              """
+                plugins {
+                    id "java-library"
+                }
+    
+                repositories {
+                    mavenCentral()
+                }
+    
+                apply from: "dependencies.gradle"
+                """,
+              //language=groovy
+              """
+                plugins {
+                    id "java-library"
+                }
+    
+                repositories {
+                    mavenCentral()
+                }
+    
+                apply from: "dependencies.gradle"
+    
+                dependencies {
+                    implementation "com.google.guava:guava:29.0-jre"
+                }
+                """
+            ),
+            buildGradle(
+              //language=groovy
+              """
+                dependencies {
+                }
+                """,
+              s -> s.path("dependencies.gradle")
+            )
+          )
+        );
+    }
+
+
     private AddDependency addDependency(@SuppressWarnings("SameParameterValue") String gav) {
         return addDependency(gav, null, null);
     }