Map JS BigInt literals to string values (#6148)

* Map JS `BigInt` literals to string values

`BigInt` can't be serialized as JSON.

* Adjust test expectation

* Rename `Long` constant to `BigInt`

Author: knutwannheden

rewrite-javascript/rewrite/src/java/type.ts

@@ -154,7 +154,7 @@ export namespace Type {
         static readonly Double = new Primitive('double');
         static readonly Float = new Primitive('float');
         static readonly Int = new Primitive('int');
-        static readonly Long = new Primitive('long');
+        static readonly BigInt = new Primitive('long');
         static readonly Short = new Primitive('short');
         static readonly String = new Primitive('String');
         static readonly Void = new Primitive('void');
@@ -168,7 +168,7 @@ export namespace Type {
             Primitive.Double,
             Primitive.Float,
             Primitive.Int,
-            Primitive.Long,
+            Primitive.BigInt,
             Primitive.Short,
             Primitive.String,
             Primitive.Void,
@@ -195,7 +195,7 @@ export namespace Type {
                 case 'int':
                     return Primitive.Int;
                 case 'long':
-                    return Primitive.Long;
+                    return Primitive.BigInt;
                 case 'short':
                     return Primitive.Short;
                 case 'String':

rewrite-javascript/rewrite/src/javascript/parser.ts

@@ -609,11 +609,12 @@ export class JavaScriptParserVisitor {
     visitNumericLiteral(node: ts.NumericLiteral): J.Literal {
         // Parse the numeric value from the text
         const text = node.text;
-        let value: number | bigint;
+        let value: number | bigint | string;
 
         // Check if it's a BigInt literal (ends with 'n')
         if (text.endsWith('n')) {
-            value = BigInt(text.slice(0, -1));
+            // TODO consider adding `JS.Literal`
+            value = text.slice(0, -1);
         } else if (text.includes('.') || text.toLowerCase().includes('e')) {
             // Floating point number
             value = parseFloat(text);
@@ -708,7 +709,8 @@ export class JavaScriptParserVisitor {
     visitBigIntLiteral(node: ts.BigIntLiteral): J.Literal {
         // Parse BigInt value, removing the 'n' suffix
         const text = node.text;
-        const value = BigInt(text.slice(0, -1));
+        // TODO consider adding `JS.Literal`
+        const value = text.slice(0, -1);
         return this.mapLiteral(node, value);
     }
 
@@ -717,6 +719,7 @@ export class JavaScriptParserVisitor {
     }
 
     visitRegularExpressionLiteral(node: ts.RegularExpressionLiteral): J.Literal {
+        // TODO consider adding `JS.Literal`
         return this.mapLiteral(node, node.text); // FIXME value not in AST
     }
 

rewrite-javascript/rewrite/src/javascript/type-mapping.ts

@@ -196,7 +196,7 @@ export class JavaScriptTypeMapping {
     private wrapperType(declaringType: (Type.FullyQualified & Type.Primitive) | Type.FullyQualified) {
         if (declaringType == Type.Primitive.String && this.stringWrapperType) {
             return this.getType(this.stringWrapperType) as Type.FullyQualified;
-        } else if ((declaringType == Type.Primitive.Double || declaringType == Type.Primitive.Long) && this.numberWrapperType) {
+        } else if ((declaringType == Type.Primitive.Double || declaringType == Type.Primitive.BigInt) && this.numberWrapperType) {
             return this.getType(this.numberWrapperType) as Type.FullyQualified;
         } else if (declaringType == Type.Primitive.Boolean && this.booleanWrapperType) {
             return this.getType(this.booleanWrapperType) as Type.FullyQualified;
@@ -808,7 +808,7 @@ export class JavaScriptTypeMapping {
             type.flags === ts.TypeFlags.BigIntLiteral ||
             type.flags === ts.TypeFlags.BigIntLike
         ) {
-            return Type.Primitive.Long;
+            return Type.Primitive.BigInt;
         } else if (
             (type.symbol !== undefined && type.symbol === this.regExpSymbol) ||
             this.checker.typeToString(type) === "RegExp"

rewrite-javascript/rewrite/test/javascript/parser/literal.test.ts

@@ -23,6 +23,7 @@ const spec = new RecipeSpec();
 describe.each([
     ['1', Type.Primitive.Double],
     ['1.0', Type.Primitive.Double],
+    ['123n', Type.Primitive.BigInt],
     ['"1"', Type.Primitive.String],
     ['true', Type.Primitive.Boolean],
     ['null', Type.Primitive.Null],

rewrite-javascript/rewrite/test/javascript/type-mapping.test.ts

@@ -129,7 +129,7 @@ describe('JavaScript type mapping', () => {
         test('should map bigint literal', async () => {
             const spec = new RecipeSpec();
             spec.recipe = markTypes((node, type) => {
-                if (node?.kind === J.Kind.Literal && typeof (node as J.Literal).value === 'bigint') {
+                if (node?.kind === J.Kind.Literal && typeof (node as J.Literal).value === 'string') {
                     return formatPrimitiveType(type);
                 }
                 return null;

rewrite-javascript/src/integTest/java/org/openrewrite/javascript/JavaScriptParserTest.java

@@ -42,7 +42,7 @@ class JavaScriptParserTest {
 
     @BeforeEach
     void before() {
-//        JavaScriptRewriteRpc.setFactory(JavaScriptRewriteRpc.builder().trace(true));
+//        JavaScriptRewriteRpc.setFactory(JavaScriptRewriteRpc.builder().inspectBrk(Paths.get("rewrite")));
         this.parser = JavaScriptParser.builder().build();
         this.ctx = new InMemoryExecutionContext();
     }
@@ -56,7 +56,7 @@ void after() {
     void helloJavaScript() {
         @Language("js")
         String helloWorld = """
-          console.info("Hello world!")
+          console.info("Hello " + 123n)
           """;
         Parser.Input input = Parser.Input.fromString(Path.of("helloworld.js"), helloWorld);
         Optional<SourceFile> javascript = parser.parseInputs(List.of(input), null, ctx).findFirst();