Skip to content

Commit 8266018

Browse files
committed
Use configuration name rather than referential identity in GradleProject configurationsExtendingFrom()
1 parent 55c33b4 commit 8266018

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

rewrite-gradle/src/main/java/org/openrewrite/gradle/AddPlatformDependency.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public class AddPlatformDependency extends ScanningRecipe<AddPlatformDependency.
7676

7777
@Option(displayName = "Configuration",
7878
description = "A configuration to use when it is not what can be inferred from usage. Most of the time this will be left empty, but " +
79-
"is used when adding a new as of yet unused dependency.",
79+
"is used when adding a new, as yet unused, dependency.",
8080
example = "implementation",
8181
required = false)
8282
@Nullable

rewrite-gradle/src/main/java/org/openrewrite/gradle/marker/GradleProject.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ public class GradleProject implements Marker, Serializable {
8080
Map<String, GradleDependencyConfiguration> nameToConfiguration = emptyMap();
8181

8282
@Builder.Default
83+
@With
8384
GradleBuildscript buildscript = new GradleBuildscript(randomId(), emptyList(), emptyMap());
8485

8586
public GradleBuildscript getBuildscript() {
@@ -139,7 +140,7 @@ public List<GradleDependencyConfiguration> configurationsExtendingFrom(
139140
continue;
140141
}
141142
for (GradleDependencyConfiguration extendsFrom : configuration.getExtendsFrom()) {
142-
if (extendsFrom == parentConfiguration) {
143+
if (extendsFrom.getName().equals(parentConfiguration.getName())) {
143144
result.add(configuration);
144145
if (transitive) {
145146
result.addAll(configurationsExtendingFrom(configuration, true));

0 commit comments

Comments
 (0)