Reduce Version allocations in dependency graph traversal (#6354)

Author: pstreef

rewrite-gradle/src/main/java/org/openrewrite/gradle/marker/GradleDependencyConfiguration.java

@@ -243,7 +243,7 @@ public List<ResolvedDependency> getResolved() {
             if (resolved == null) {
                 List<ResolvedDependency> newResolved = new ArrayList<>(getDirectResolved());
                 Map<GroupArtifact, ResolvedDependency> alreadyResolved = new HashMap<>();
-                Map<GroupArtifact, Version> versionCache = new HashMap<>();
+                Map<String, Version> versionCache = new HashMap<>();
                 resolveTransitiveDependencies(newResolved, alreadyResolved, versionCache);
                 resolved = new ArrayList<>(alreadyResolved.values());
             }
@@ -392,7 +392,7 @@ void unsafeSetDirectResolved(List<ResolvedDependency> directResolved) {
         this.directResolved = directResolved;
     }
 
-    private static void resolveTransitiveDependencies(List<ResolvedDependency> resolved, Map<GroupArtifact, ResolvedDependency> alreadyResolved, Map<GroupArtifact, Version> versionCache) {
+    private static void resolveTransitiveDependencies(List<ResolvedDependency> resolved, Map<GroupArtifact, ResolvedDependency> alreadyResolved, Map<String, Version> versionCache) {
         for (ResolvedDependency dependency : resolved) {
             GroupArtifact ga = dependency.getGav().asGroupArtifact();
             if (alreadyResolved.containsKey(ga)) {
@@ -401,13 +401,12 @@ private static void resolveTransitiveDependencies(List<ResolvedDependency> resol
                     continue;
                 }
 
-                Version newVersion = new Version(dependency.getVersion());
-                Version presentVersion = versionCache.computeIfAbsent(ga, ignored -> new Version(alreadyPresent.getVersion()));
+                Version newVersion = versionCache.computeIfAbsent(dependency.getVersion(), Version::new);
+                Version presentVersion = versionCache.computeIfAbsent(alreadyPresent.getVersion(), Version::new);
                 int compared = presentVersion.compareTo(newVersion);
                 if (compared > 0 || (compared == 0 && alreadyPresent.getDependencies().size() == dependency.getDependencies().size())) {
                     continue;
                 }
-                versionCache.replace(ga, newVersion);
             }
             alreadyResolved.put(ga, dependency);
             resolveTransitiveDependencies(dependency.getDependencies(), alreadyResolved, versionCache);