How to add test for copying a binary file?

[wimdeblauwe]

I am copying some binary files in my recipe from the classpath of the recipe itself. So my recipe jar contains binary files that will be copied to the target project at a certain location. My code reads the "source file" from the classpath using getClass().getResourceAsStream() and then uses the Binary file passing in the resourceAsStream.readAllBytes() to its constructor.

When I run the test I have, I get "The recipe generated source files the test did not expect", listing all the files that the recipe generates. Which is great in itself, but now I don't know how to state that I do expect these binary fiiles?

I have looked at SourceSpecs.other, but that needs String values.

Ideally, I want to just state that I expect files to be present at a certain path. Maybe some kind of hash/checksum check of the files would be handy, but not really required for my use case.

[timtebeek]

hi @wimdeblauwe ; I'd expect that case to be covered through this other method:

rewrite/rewrite-test/src/main/java/org/openrewrite/test/SourceSpecs.java

Lines 43 to 47 in a98d83d

	static SourceSpecs other(@Nullable String before, Consumer<SourceSpec<Quark>> spec) {
	SourceSpec<Quark> quark = new SourceSpec<>(Quark.class, null, QuarkParser.builder(), before, null);
	spec.accept(quark);
	return quark;
	}

You should be able to call that with other(null, spec -> { }) I think, but I'm not a 100% sure. If that doesn't work then perhaps we ought to add binary as a set of methods on SourceSpecs.

[wimdeblauwe]

It unfortunately does not seem to work. I get "Either before or after must be specified in a SourceSpec" when I do this.

[Jenson3210]

rewrite/rewrite-test/src/main/java/org/openrewrite/test/RewriteTest.java

Line 430 in 402be47

assertThat(sourceSpec.after).as("Either before or after must be specified in a SourceSpec").isNotNull();

I do not think this is possible in the current RewriteTest. Even if we would ignore this one line when the spec is expecting a Quark, few lines later the code will attempt to print the Quark to compare the after state and that won't work either.

[timtebeek]

Then indeed we'd ought to add a binary as a set of methods on SourceSpecs to support this testing scenario.

[shanman190]

We tend to do other (Quark) to Remote just fine.
https://github.com/openrewrite/rewrite/blob/main/rewrite-gradle%2Fsrc%2Ftest%2Fjava%2Forg%2Fopenrewrite%2Fgradle%2FUpdateGradleWrapperTest.java

I don't think we even use the Binary anymore at all. It was an early attempt at how to represent binary files that later was replaced with Remote instead.