Recipe UseLombokSetter deletes setter if annotations are present

[janmaterne]

What version of OpenRewrite are you using?

rewrite-maven-plugin : 6.1.0
rewrite-migrate-java : 3.2.0

How are you running OpenRewrite?

Standalone Maven project

		<profile>
			<id>rewrite</id>
			<build>
				<plugins>
					<plugin>
						<groupId>org.openrewrite.maven</groupId>
						<artifactId>rewrite-maven-plugin</artifactId>
						<version>6.1.0</version>
						<executions>
							<execution>
								<goals>
									<goal>run</goal>
								</goals>
								<phase>verify</phase>
							</execution>
						</executions>
						<configuration>
							<exportDatatables>true</exportDatatables>
							<activeRecipes>
								<recipe>org.openrewrite.java.migrate.lombok.UseLombokGetter</recipe>
								<recipe>org.openrewrite.java.migrate.lombok.UseLombokSetter</recipe>
							</activeRecipes>
						</configuration>
						<dependencies>
							<dependency>
								<groupId>org.openrewrite.recipe</groupId>
								<artifactId>rewrite-migrate-java</artifactId>
								<version>3.2.0</version>
							</dependency>
						</dependencies>
					</plugin>

What is the smallest, simplest way to reproduce the problem?

Example is using Lombok + Spring.

@Service
@Slf4j
public class MyService {

	@Getter
	private String configuration;
	@Getter
	private MyRepository repository;

	@Value("${spring.application.name}")
	public void setConfiguration(String configuration) {
		this.configuration = configuration;
	}

	@Autowired
	public void setRepository(MyRepository repository) {
		this.repository = repository;
	}
}

What did you expect to see?

@Service
@Slf4j
public class MyService {

	@Getter
	@Setter
	@Value("${spring.application.name}")
	private String configuration;
	@Getter
	@Setter
	@Autowired
	private MyRepository repository;
}

What did you see instead?

@Service
@Slf4j
public class MyService {

	@Getter
	@Setter
	private String configuration;
	@Getter
	@Setter
	private MyRepository repository;
}

The recipe deletes the setter method but it also deletes given annotations.
The recipe should delete the setter if an annotation is present or moves the annotation to the field - if possible.

[MBoegers]

Hi @janmaterne 👋 thanks for reporting. Indeed, that breaks application code and has to be addressed.
See openrewrite/rewrite-migrate-java#672 for a quick fix that prevent the recipe from migration if the method has more annotations than just @Overwrite.

Would you be interested in working on a more compete fix?

[jevanlingen]

For a real fix, we should use the onMethod=@__({@AnnotationsHere}) option:

To put annotations on the generated method, you can use onMethod=@__({@AnnotationsHere}); Be careful though! This is an experimental feature. For more details see the documentation on the onX feature. - docs

So then for OP's example the code would turn into:

@Service
@Slf4j
public class MyService {

	@Getter
	@Setter(onMethod = @__(@Value("${spring.application.name}")))
	private String configuration;
	@Getter
	@Setter(onMethod = @__(@Autowired))
	private MyRepository repository;
}

[timtebeek]

• For now addressed through Omit migration to @Setter annotated field of other annotations are present rewrite-migrate-java#672

Not sure if the alternative would help code readability, but if you feel strongly about it you can open a draft PR on https://github.com/openrewrite/rewrite-migrate-java/ with altered test cases.

Thanks again for the report!