Tests to exercise the remaining branches in file_browser/index.html

rebkwok · rebkwok · commit 4c687cf1ae2f · 2024-02-22T14:17:39.000Z
diff --git a/tests/integration/test_views.py b/tests/integration/test_views.py
@@ -66,6 +66,14 @@ def test_workspace_view_with_file(client_with_permission, ui_options):
     assert "foobar" in response.rendered_content
 
 
+def test_workspace_view_with_html_file(client_with_permission, ui_options):
+    factories.write_workspace_file(
+        "workspace", "file.html", "<html><body>foobar</body></html>"
+    )
+    response = client_with_permission.get("/workspaces/view/workspace/file.html")
+    assert "foobar" in response.rendered_content
+
+
 def test_workspace_view_with_404(client_with_permission):
     factories.create_workspace("workspace")
     response = client_with_permission.get("/workspaces/view/workspace/no_such_file.txt")
@@ -80,6 +88,14 @@ def test_workspace_view_redirects_to_directory(client_with_permission):
     assert response.headers["Location"] == "/workspaces/view/workspace/some_dir/"
 
 
+def test_workspace_view_directory_with_sub_directory(client_with_permission):
+    workspace = factories.create_workspace("workspace")
+    factories.write_workspace_file(workspace, "sub_dir/file.txt")
+    response = client_with_permission.get("/workspaces/view/workspace", follow=True)
+    assert "sub_dir" in response.rendered_content
+    assert "file.txt" in response.rendered_content
+
+
 def test_workspace_view_redirects_to_file(client_with_permission):
     factories.write_workspace_file("workspace", "file.txt")
     response = client_with_permission.get("/workspaces/view/workspace/file.txt/")
@@ -309,9 +325,7 @@ def test_request_view_with_file(client_with_permission, ui_options):
     release_request = factories.create_release_request("workspace")
     factories.write_workspace_file("workspace", "file.txt", "foobar")
     factories.create_filegroup(
-        release_request,
-        group_name="default_group",
-        filepaths=["file.txt"]
+        release_request, group_name="default_group", filepaths=["file.txt"]
     )
 
     response = client_with_permission.get(
@@ -322,14 +336,32 @@ def test_request_view_with_file(client_with_permission, ui_options):
 
 
 def test_request_view_with_submitted_request(client_with_permission, ui_options):
-    release_request = factories.create_release_request("workspace", status=Status.SUBMITTED)
+    release_request = factories.create_release_request(
+        "workspace", status=Status.SUBMITTED
+    )
     response = client_with_permission.get(
         f"/requests/view/{release_request.id}", follow=True
     )
     assert "Reject Request" in response.rendered_content
     assert "Release Files" in response.rendered_content
 
 
+def test_request_view_with_authored_request_file(client_with_permission, ui_options):
+    release_request = factories.create_release_request(
+        "workspace",
+        user=User.from_session(client_with_permission.session),
+        status=Status.SUBMITTED,
+    )
+    factories.write_workspace_file("workspace", "file.txt", "foobar")
+    factories.create_filegroup(
+        release_request, group_name="default_group", filepaths=["file.txt"]
+    )
+    response = client_with_permission.get(
+        f"/requests/view/{release_request.id}/file.txt", follow=True
+    )
+    assert "Remove this file" in response.rendered_content
+
+
 def test_request_view_with_404(client_with_permission):
     release_request = factories.create_release_request("workspace")
     response = client_with_permission.get(
@@ -521,12 +553,16 @@ def test_requests_release_jobserver_403(client_with_permission, release_files_st
     "content_type,content,should_contain_iframe",
     [
         ("text/plain", b"An error from job-server", False),
-        ("text/html", b"<p>An error from job-server</p>", True)
-    ]
+        ("text/html", b"<p>An error from job-server</p>", True),
+    ],
 )
 def test_requests_release_jobserver_403_with_debug(
-    client_with_permission, release_files_stubber, settings,
-    content_type, content, should_contain_iframe
+    client_with_permission,
+    release_files_stubber,
+    settings,
+    content_type,
+    content,
+    should_contain_iframe,
 ):
     settings.DEBUG = True
     release_request = factories.create_release_request(
