Merge pull request #87 from opensafely-core/messages

Add minimal alert messages

Author: rebkwok

airlock/settings.py

@@ -14,6 +14,7 @@
 from pathlib import Path
 
 import django.dispatch
+from django.contrib import messages
 from django.db.backends.signals import connection_created
 
 
@@ -233,3 +234,13 @@ def run_connection_init_queries(*, connection, **kwargs):
 
 # BACKEND is global env var on backends
 BACKEND = os.environ.get("BACKEND", "test")
+
+# Messages
+# https://docs.djangoproject.com/en/3.0/ref/contrib/messages/
+MESSAGE_TAGS = {
+    messages.DEBUG: "alert-info",
+    messages.INFO: "alert-info",
+    messages.SUCCESS: "alert-success",
+    messages.WARNING: "alert-warning",
+    messages.ERROR: "alert-danger",
+}

airlock/views.py

@@ -3,6 +3,7 @@
 import requests
 from django import forms
 from django.conf import settings
+from django.contrib import messages
 from django.core.exceptions import PermissionDenied
 from django.http import Http404
 from django.shortcuts import redirect
@@ -156,6 +157,7 @@ def workspace_add_file_to_request(request, workspace_name):
     release_request = api.get_current_request(workspace_name, request.user, create=True)
     api.add_file_to_request(release_request, relpath, request.user)
 
+    messages.success(request, "File has been added to request")
     # redirect to this just added file
     return redirect(release_request.get_url_for_path(relpath))
 
@@ -233,6 +235,7 @@ def request_submit(request, request_id):
     except api.RequestPermissionDenied as exc:
         raise PermissionDenied(str(exc))
 
+    messages.success(request, "Request has been submitted")
     return redirect(release_request.get_absolute_url())
 
 
@@ -245,6 +248,7 @@ def request_reject(request, request_id):
     except api.RequestPermissionDenied as exc:
         raise PermissionDenied(str(exc))
 
+    messages.error(request, "Request has been rejected")
     return redirect(release_request.get_absolute_url())
 
 
@@ -273,4 +277,5 @@ def request_release_files(request, request_id):
             raise PermissionDenied() from None
         raise
 
+    messages.success(request, "Files have been released to jobs.opensafely.org")
     return redirect(release_request.get_absolute_url())