Skip to content

Commit 2421176

Browse files
committed
Add TODOs
1 parent a8fddcf commit 2421176

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

osg_configure/configure_modules/gratia.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -227,6 +227,9 @@ def configure(self, attributes):
227227
else:
228228
self.options['resource'].value = attributes['OSG_SITE_NAME']
229229

230+
# TODO Why is gratia looking at attributes instead of just using the options
231+
# directly? If it's not necessary, drop the OSG_HOSTNAME attribute from
232+
# siteinformation.py.
230233
if 'OSG_HOSTNAME' not in attributes:
231234
self.log('Hostname of this machine not specified. Please give this '
232235
'in the host_name option in the Site Information section',

osg_configure/configure_modules/siteinformation.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ def __init__(self, *args, **kwargs):
3333
configfile.Option(name='host_name',
3434
required=MANDATORY_ON_CE,
3535
mapping='OSG_HOSTNAME'),
36+
# ^^ the OSG_HOSTNAME mapping is used by the gratia module, though not sure why.
3637
'resource':
3738
configfile.Option(name='resource',
3839
required=MANDATORY,

0 commit comments

Comments
 (0)