Skip to content

Commit 249c4a8

Browse files
committed
Remove separate XRootD standalone port
All XRootD implementations use /etc/xrootd/config.d so they can't be installed side-by-side and be expected to work
1 parent 0bdbcb0 commit 249c4a8

File tree

2 files changed

+9
-12
lines changed

2 files changed

+9
-12
lines changed

osgtest/tests/test_150_xrootd.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66
import osgtest.library.osgunittest as osgunittest
77

88

9-
XROOTD_PORT = 1096 # chosen so it doesn't conflict w/ the stashcache instances
10-
119
XROOTD_CFG_TEXT = """\
1210
cms.space min 2g 5g
1311
xrootd.seclib /usr/lib64/libXrdSec-4.so
@@ -20,7 +18,6 @@
2018
%s
2119
acc.authdb /etc/xrootd/auth_file
2220
ofs.authorize
23-
xrd.port %d
2421
"""
2522

2623
AUTHFILE_TEXT = """\
@@ -41,7 +38,6 @@ def test_01_start_xrootd(self):
4138
core.config['certs.xrootdkey'] = '/etc/grid-security/xrd/xrdkey.pem'
4239
core.config['xrootd.config'] = '/etc/xrootd/xrootd-clustered.cfg'
4340
core.config['xrootd.config-extra'] = '/etc/xrootd/config.d/99-osg-test.cfg'
44-
core.config['xrootd.port'] = XROOTD_PORT
4541
core.config['xrootd.multiuser'] = False
4642
core.state['xrootd.started-server'] = False
4743
core.state['xrootd.backups-exist'] = False
@@ -69,12 +65,13 @@ def test_01_start_xrootd(self):
6965

7066
if core.PackageVersion('xrootd') < '1:4.9.0':
7167
files.append(core.config['xrootd.config'],
72-
XROOTD_CFG_TEXT % (sec_protocol, core.config['xrootd.port']),
68+
XROOTD_CFG_TEXT % sec_protocol,
7369
owner='xrootd', backup=True)
7470
else:
7571
files.write(core.config['xrootd.config-extra'],
76-
XROOTD_CFG_TEXT % (sec_protocol, core.config['xrootd.port']),
72+
XROOTD_CFG_TEXT % sec_protocol,
7773
owner='xrootd', backup=True, chmod=0o644)
74+
7875
authfile = '/etc/xrootd/auth_file'
7976
files.write(authfile, AUTHFILE_TEXT, owner="xrootd", chown=(user.pw_uid, user.pw_gid))
8077

osgtest/tests/test_450_xrootd.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def test_01_xrdcp_local_to_server(self):
2929
os.chown(temp_dir, user[2], user[3])
3030
hostname = socket.getfqdn()
3131
os.chmod(temp_dir, 0o777)
32-
xrootd_url = 'root://%s:%d/%s/copied_file.txt' % (hostname, core.config['xrootd.port'], temp_dir)
32+
xrootd_url = 'root://%s/%s/copied_file.txt' % (hostname, temp_dir)
3333
command = ('xrdcp', '--debug', '3', TestXrootd.__data_path, xrootd_url)
3434

3535
status, stdout, stderr = core.system(command, user=True)
@@ -62,7 +62,7 @@ def test_03_xrdcp_server_to_local(self):
6262
f = open(temp_source_dir + "/copied_file.txt", "w")
6363
f.write("This is some test data for an xrootd test.")
6464
f.close()
65-
xrootd_url = 'root://%s:%d/%s/copied_file.txt' % (hostname, core.config['xrootd.port'], temp_source_dir)
65+
xrootd_url = 'root://%s/%s/copied_file.txt' % (hostname, temp_source_dir)
6666
local_path = temp_target_dir + '/copied_file.txt'
6767
command = ('xrdcp', '--debug', '3', xrootd_url, local_path)
6868

@@ -86,12 +86,12 @@ def test_04_xrootd_fuse(self):
8686
os.mkdir(TestXrootd.__fuse_path)
8787
hostname = socket.getfqdn()
8888

89-
#For some reason, sub process hangs on fuse processes, use os.system
90-
os.system("mount -t fuse -o rdr=root://localhost:%d//tmp,uid=xrootd xrootdfs %s" %
91-
(core.config['xrootd.port'], TestXrootd.__fuse_path))
89+
# For some reason, sub process hangs on fuse processes, use os.system
90+
os.system("mount -t fuse -o rdr=root://localhost//tmp,uid=xrootd xrootdfs %s" %
91+
TestXrootd.__fuse_path)
9292

9393
# Copy a file in and see if it made it into the fuse mount
94-
xrootd_url = 'root://%s:%d/%s/copied_file.txt' % (hostname, core.config['xrootd.port'], "/tmp")
94+
xrootd_url = 'root://%s/%s/copied_file.txt' % (hostname, "/tmp")
9595
core.system(['xrdcp', '--debug', '3', TestXrootd.__data_path, xrootd_url], user=True)
9696

9797
self.assert_(os.path.isfile("/tmp/copied_file.txt"), "Test file not uploaded to FUSE mount")

0 commit comments

Comments
 (0)