Skip to content

Commit 52f32db

Browse files
authored
Merge pull request #212 from brianhlin/retire-osg34
Retire 3.4; add 3.5 decorators
2 parents fd7063e + 72fd1de commit 52f32db

20 files changed

+43
-316
lines changed

files/test_sequence

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ test_140_lcmaps
1010
test_150_xrootd
1111
test_155_stashcache
1212
test_158_xrootd_tpc
13-
test_160_rsv
1413
test_170_pbs
1514
test_180_cvmfs
1615
test_190_condorce
@@ -28,7 +27,6 @@ test_430_uberftp
2827
test_450_xrootd
2928
test_460_stashcache
3029
test_465_xrootd_tpc
31-
test_470_rsv
3230
test_490_jobs
3331
test_550_condorce
3432
test_580_gfal2util
@@ -38,7 +36,6 @@ test_770_myproxy
3836
test_780_voms
3937
test_790_condorce
4038
test_820_cvmfs
41-
test_830_rsv
4239
test_835_stashcache
4340
test_838_xrootd_tpc
4441
test_840_xrootd

osgtest/library/core.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
# prefix each key with "COMP.", where "COMP" is a short lowercase string that
4646
# indicates which component the test belongs to, or "general." for truly cross-
4747
# cutting objects.
48-
state = {}
48+
state = {'proxy.valid': False} # TODO: Drop 'proxy.valid' after we drop support for OSG 3.5
4949

5050
class DummyClass(object):
5151
"""A class that ignores all function calls; useful for testing"""
@@ -751,7 +751,7 @@ class TestFoo(osgunittest.OSGTestCase):
751751
def test_bar_34_only(self):
752752
...
753753
"""
754-
releases = map(str, releases) # convert float args to str
754+
releases = [str(x) for x in releases] # convert float args to str
755755
def osg_release_decorator(fn):
756756
def run_fn_if_osg_release_ok(*args, **kwargs):
757757
if osg_release().version in releases:

osgtest/tests/test_130_gridftp.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@
44

55
class TestStartGridFTP(osgunittest.OSGTestCase):
66

7+
@core.osgrelease(3.5)
8+
def setUp(self):
9+
pass
10+
711
def test_01_start_gridftp(self):
812
core.state['gridftp.started-server'] = False
913
core.state['gridftp.running-server'] = False

osgtest/tests/test_140_lcmaps.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ class TestLcMaps(osgunittest.OSGTestCase):
66

77
required_rpms = ['lcmaps', 'lcmaps-db-templates', 'vo-client', 'vo-client-lcmaps-voms']
88

9+
@core.osgrelease(3.5)
10+
def setUp(self):
11+
pass
12+
913
def test_01_configure(self):
1014
core.config['lcmaps.db'] = '/etc/lcmaps.db'
1115
core.config['lcmaps.gsi-authz'] = '/etc/grid-security/gsi-authz.conf'

osgtest/tests/test_150_xrootd.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ def test_01_configure_xrootd(self):
102102

103103
core.state['xrootd.backups-exist'] = True
104104

105+
@core.osgrelease(3.5)
105106
def test_02_configure_hdfs(self):
106107
core.skip_ok_unless_installed('xrootd-hdfs')
107108
hdfs_config = "ofs.osslib /usr/lib64/libXrdHdfs.so"

osgtest/tests/test_160_rsv.py

Lines changed: 0 additions & 32 deletions
This file was deleted.

osgtest/tests/test_220_myproxy.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@
77

88
class TestStartMyProxy(osgunittest.OSGTestCase):
99

10+
@core.osgrelease(3.5)
11+
def setUp(self):
12+
pass
13+
1014
def test_01_config_certs(self):
1115
core.config['certs.myproxycert'] = '/etc/grid-security/myproxy/hostcert.pem'
1216
core.config['certs.myproxykey'] = '/etc/grid-security/myproxy/hostkey.pem'

osgtest/tests/test_280_gsiopenssh.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626

2727

2828
class TestStartGSIOpenSSH(osgunittest.OSGTestCase):
29+
@core.osgrelease('3.5')
2930
def setUp(self):
3031
core.skip_ok_unless_installed('gsi-openssh-server', 'gsi-openssh-clients')
3132

osgtest/tests/test_400_proxy.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@
55

66
class TestGridProxyInit(osgunittest.OSGTestCase):
77

8+
@core.osgrelease(3.5)
9+
def setUp(self):
10+
pass
11+
812
def test_01_remove_proxy(self):
913
core.skip_ok_unless_installed('globus-proxy-utils')
1014
# If there is no pre-existing proxy file, the following command will

osgtest/tests/test_403_myproxy.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@
55

66
class TestMyProxy(osgunittest.OSGTestCase):
77

8+
@core.osgrelease(3.5)
9+
def setUp(self):
10+
pass
11+
812
def test_01_remove_proxy(self):
913
core.skip_ok_unless_installed('myproxy', 'myproxy-server')
1014
self.skip_ok_unless(core.state['myproxy.started-server'], 'MyProxy server failed to start')

0 commit comments

Comments
 (0)