Skip to content

Commit 7a4205a

Browse files
Merge pull request #181 from brianhlin/fixup-ce-skips
Add bad skip messages for tests that need a proxy cert
2 parents 2ebe8fa + 0e2074d commit 7a4205a

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

osgtest/tests/test_410_jobs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def test_02_condor_ce_run_condor(self):
5858
self.skip_bad_unless(service.is_running('condor-ce'), 'ce not running')
5959
self.skip_bad_unless(service.is_running('condor'), 'condor not running')
6060
self.skip_bad_unless(core.state['jobs.env-set'], 'job environment not set')
61-
self.skip_bad_unless(core.state['proxy.created'])
61+
self.skip_bad_unless(core.state['proxy.created'], 'requires a proxy cert')
6262

6363
command = ('condor_ce_run', '-r', '%s:9619' % core.get_hostname(), '/bin/env')
6464
self.run_job_in_tmp_dir(command, 'condor_ce_run a Condor job')

osgtest/tests/test_550_condorce.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ def test_02_queue(self):
8383

8484
def test_03_ping(self):
8585
self.general_requirements()
86-
self.skip_bad_unless(core.state['proxy.created'])
86+
self.skip_bad_unless(core.state['proxy.created'], 'requires a proxy cert')
8787

8888
command = ('condor_ce_ping', 'WRITE', '-verbose')
8989
stdout, _, _ = core.check_system(command, 'ping using GSI and gridmap', user=True)
@@ -92,7 +92,7 @@ def test_03_ping(self):
9292
def test_04_trace(self):
9393
self.general_requirements()
9494
self.skip_bad_unless(core.state['condor-ce.schedd-ready'], 'CE schedd not ready to accept jobs')
95-
self.skip_bad_unless(core.state['proxy.created'])
95+
self.skip_bad_unless(core.state['proxy.created'], 'requires a proxy cert')
9696

9797
cwd = os.getcwd()
9898
os.chdir('/tmp')
@@ -108,7 +108,7 @@ def test_05_pbs_trace(self):
108108
core.skip_ok_unless_installed('torque-mom', 'torque-server', 'torque-scheduler', 'torque-client', 'munge',
109109
by_dependency=True)
110110
self.skip_ok_unless(service.is_running('pbs_server'), 'pbs service not running')
111-
self.skip_bad_unless(core.state['proxy.created'])
111+
self.skip_bad_unless(core.state['proxy.created'], 'requires a proxy cert')
112112
self.run_blahp_trace('pbs')
113113

114114
def test_06_slurm_trace(self):
@@ -117,7 +117,7 @@ def test_06_slurm_trace(self):
117117
self.skip_bad_unless(service.is_running('munge'), 'slurm requires munge')
118118
self.skip_bad_unless(core.state['condor-ce.schedd-ready'], 'CE schedd not ready to accept jobs')
119119
self.skip_ok_unless(service.is_running(core.config['slurm.service-name']), 'slurm service not running')
120-
self.skip_bad_unless(core.state['proxy.created'])
120+
self.skip_bad_unless(core.state['proxy.created'], 'requires a proxy cert')
121121
self.run_blahp_trace('slurm')
122122

123123
def test_07_ceview(self):

0 commit comments

Comments
 (0)