Skip to content

Commit 817aa71

Browse files
committed
Fix direction of version comparison (SOFTWARE-3396)
We only want to add this xrootd_policy section to lcmaps.db for xrootd-lcmaps < 1.4.0, that is, skip if xrootd-lcmaps >= 1.4.0 Also, per Mat's suggestion, i am renaming the name of the test to say that it is for the "old" xrootd_policy ... Soon we'll add a more clear helper to do package version checks.
1 parent 309da31 commit 817aa71

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

osgtest/tests/test_14_lcmaps.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ def test_01_configure(self):
2020
"globus_mapping liblcas_lcmaps_gt4_mapping.so lcmaps_callout\n",
2121
owner='lcmaps')
2222

23-
def test_02_xrootd_policy(self):
23+
def test_02_old_xrootd_policy(self):
2424
core.skip_ok_unless_installed('xrootd-lcmaps', *self.required_rpms)
25-
self.skip_ok_unless(core.package_version_compare('xrootd-lcmaps', '1.4.0') >= 0)
25+
self.skip_ok_if(core.package_version_compare('xrootd-lcmaps', '1.4.0') >= 0)
2626

2727
files.append(core.config['lcmaps.db'],
2828
'''xrootd_policy:

0 commit comments

Comments
 (0)