Skip to content

Commit d401ffd

Browse files
committed
Explain BADSKIP
1 parent 286565e commit d401ffd

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

osgtest/tests/test_460_stashcache.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,14 @@ def assertCached(self, name, contents):
3636
self.assertEqual(contents, files.read(fpath, as_single_string=True),
3737
"cached file %s contents do not match expected" % name)
3838

39+
def skip_bad_unless_running(self, *services):
40+
for svc in services:
41+
self.skip_bad_unless(service.is_running(svc), "%s not running" % svc)
42+
3943
@core.elrelease(7,8)
4044
def setUp(self):
4145
core.skip_ok_unless_installed("stashcache-origin-server", "stashcache-cache-server", "stashcache-client")
42-
self.skip_bad_unless(service.is_running("xrootd@stashcache-origin-server"))
43-
self.skip_bad_unless(service.is_running("xrootd@stashcache-cache-server"))
46+
self.skip_bad_unless_running("xrootd@stashcache-origin-server", "xrootd@stashcache-cache-server")
4447

4548
def test_01_create_files(self):
4649
xrootd_user = pwd.getpwnam("xrootd")

0 commit comments

Comments
 (0)