Skip to content

Integration of client & ml model id in end-to-end ml streaming flow #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Aug 15, 2025
Merged

Integration of client & ml model id in end-to-end ml streaming flow #196

merged 29 commits into from
Aug 15, 2025

Conversation

AHReccese
Copy link
Member

@AHReccese AHReccese commented Feb 19, 2025 •
edited
Loading

Reference Issues/PRs

This is the beginning PR of handling these things. Expect multiple upcoming PRs. I didn't want to make this a giant PR. This is for REST protocol. addition Websocket + refactorings will come in next PRs.

#39

What does this implement/fix? Explain your changes.

Any other comments?

@AHReccese
/register/ endpoint to register a new client
74c6696
@AHReccese
/request_model_id/ endpoint to request a new model id
27d8700
@AHReccese
/clients/ endpoint to get all clients
2b405ee
@AHReccese
/client/models/ endpoint to request a specific model within a speci…
0eabbb5 
…fic client
@AHReccese
integration with previous 4 endpoints in RESTClientCommunicator
f374552
@AHReccese
update previous endpoints to apply client/model id check/filter
aae314a
@AHReccese
pass download information to PyMiloServer in `WebSocketServerCommun…
ec3c8b6 
…icator`
@AHReccese
uuid used to generate universal unique ids
885243c
@AHReccese
use HTTPException to handle erros
3c96d37
@AHReccese
integrate id creation/allocation for model and client in PyMiloClient
4ac4155
@AHReccese
integrate id creation/allocation for model and client in PyMiloServer
47eb6d1
@AHReccese
develop id creation/allocation functions for ml model and client in P…
043de44 
…yMiloServer
@AHReccese
add client_id and model_id to scenario3
28a6b85
@AHReccese
add init client/model in PyMiloServer setup
a41b118
@AHReccese
add client/model initiation
244a5a9
@AHReccese
fulfill docstring
440ecdc
@AHReccese
run autopep8.sh
e732e5f
@AHReccese AHReccese added enhancement New feature or request new feature major major changes, to be reviewed in 10 days labels Feb 19, 2025
@AHReccese AHReccese added this to the pymilo v1.3 milestone Feb 19, 2025
@AHReccese AHReccese self-assigned this Feb 19, 2025
@AHReccese AHReccese modified the milestones: pymilo v1.3, pymilo v1.4 Feb 25, 2025
@AHReccese
Copy link
Member Author

Let me know you final feedback on this, so I can plan the rest.
@sepandhaghighi

@AHReccese AHReccese removed the request for review from sepandhaghighi June 10, 2025 01:32
@AHReccese AHReccese requested a review from sepandhaghighi June 30, 2025 21:02
@AHReccese
Copy link
Member Author

@sepandhaghighi

I've applied major updates on PymiloClient, PymiloServer, Communication interfaces (for REST API) and also I've applied allowance, registration, multi model allocation and etc. capabilities.

Let me know your thoughts and review on this.

In the next PRs, I will reflect these changes to Websocket protocol.

@AHReccese
Copy link
Member Author

@sepandhaghighi kind reminder!
Let me know if I can do something to help.

sepandhaghighi
sepandhaghighi approved these changes Aug 15, 2025
View reviewed changes
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AHReccese Thank you for your hard work! 💯
LGTM! 🔥
There are a few minor docstring issues (mixed type structure), but I believe they are outside the scope of this major PR, so we will handle them in a separate PR. Feel free to squash and merge this PR after resolving any potential conflicts

@AHReccese AHReccese merged commit 11331a8 into dev Aug 15, 2025
22 checks passed
@AHReccese AHReccese deleted the add/allocate_id branch August 15, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sepandhaghighi sepandhaghighi sepandhaghighi approved these changes

Assignees

@AHReccese AHReccese

Labels
enhancement New feature or request major major changes, to be reviewed in 10 days new feature
Projects
None yet
Milestone
pymilo v1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@AHReccese @sepandhaghighi