Skip to content

Commit 5915a24

Browse files
committed
Fix compatibility with nightly
Fixes #470
1 parent 2b8dfa6 commit 5915a24

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

InteractiveHtmlBom/ecad/kicad.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -535,7 +535,10 @@ def parse_footprints(self):
535535
if hasattr(f_copy, 'GetFootprintRect'):
536536
footprint_rect = f_copy.GetFootprintRect()
537537
else:
538-
footprint_rect = f_copy.GetBoundingBox(False, False)
538+
try:
539+
footprint_rect = f_copy.GetBoundingBox(False, False)
540+
except TypeError:
541+
footprint_rect = f_copy.GetBoundingBox(False)
539542
bbox = {
540543
"pos": self.normalize(f.GetPosition()),
541544
"relpos": self.normalize(footprint_rect.GetPosition()),

InteractiveHtmlBom/web/ibom.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -745,7 +745,6 @@ function populateBomBody(placeholderColumn = null, placeHolderElements = null) {
745745
}
746746
bom.appendChild(tr);
747747
var handler = createRowHighlightHandler(tr.id, references, netname);
748-
//tr.onmousemove = handler; /* Made a choice in settings */
749748
if (settings.highlightRowOnClick) {
750749
tr.onmousedown = handler;
751750
} else {

InteractiveHtmlBom/web/util.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -450,7 +450,7 @@ function overwriteSettings(newSettings) {
450450
setRedrawOnDrag(settings.redrawOnDrag);
451451
document.getElementById("dragCheckbox").checked = settings.redrawOnDrag;
452452
setHighlightRowOnClick(settings.highlightRowOnClick);
453-
document.getElementById("highlightRowOnClickCheckbox").checked = settings.highlightRowOnClick;
453+
document.getElementById("highlightRowOnClickCheckbox").checked = settings.highlightRowOnClick;
454454
setDarkMode(settings.darkMode);
455455
document.getElementById("darkmodeCheckbox").checked = settings.darkMode;
456456
setHighlightPin1(settings.highlightpin1);

0 commit comments

Comments
 (0)