Skip to content

Commit 84c4db8

Browse files
committed
Fix wxCheckListBox's stubborn height issues
Fixes #81 ... I hope
1 parent b53826c commit 84c4db8

File tree

4 files changed

+25
-3
lines changed

4 files changed

+25
-3
lines changed

InteractiveHtmlBom/dialog/dialog_base.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -311,6 +311,7 @@ def __init__( self, parent, id = wx.ID_ANY, pos = wx.DefaultPosition, size = wx.
311311
bSizer32.Fit( self )
312312

313313
# Connect Events
314+
self.Bind( wx.EVT_SIZE, self.OnSize )
314315
self.m_button12.Bind( wx.EVT_BUTTON, self.OnNameFormatHintClick )
315316
self.m_button1.Bind( wx.EVT_BUTTON, self.OnComponentSortOrderUp )
316317
self.m_button2.Bind( wx.EVT_BUTTON, self.OnComponentSortOrderDown )
@@ -324,6 +325,9 @@ def __del__( self ):
324325

325326

326327
# Virtual event handlers, overide them in your derived class
328+
def OnSize( self, event ):
329+
event.Skip()
330+
327331
def OnNameFormatHintClick( self, event ):
328332
event.Skip()
329333

@@ -462,6 +466,7 @@ def __init__( self, parent, id = wx.ID_ANY, pos = wx.DefaultPosition, size = wx.
462466
bSizer42.Fit( self )
463467

464468
# Connect Events
469+
self.Bind( wx.EVT_SIZE, self.OnSize )
465470
self.netlistFilePicker.Bind( wx.EVT_FILEPICKER_CHANGED, self.OnNetlistFileChanged )
466471
self.m_button1.Bind( wx.EVT_BUTTON, self.OnExtraFieldsUp )
467472
self.m_button2.Bind( wx.EVT_BUTTON, self.OnExtraFieldsDown )
@@ -472,6 +477,9 @@ def __del__( self ):
472477

473478

474479
# Virtual event handlers, overide them in your derived class
480+
def OnSize( self, event ):
481+
event.Skip()
482+
475483
def OnNetlistFileChanged( self, event ):
476484
event.Skip()
477485

InteractiveHtmlBom/dialog/settings_dialog.py

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,13 @@ def OnNameFormatHintClick(self, event):
162162
wx.MessageBox(self.FILE_NAME_FORMAT_HINT, 'File name format help',
163163
style=wx.ICON_NONE|wx.OK)
164164

165+
def OnSize(self, event):
166+
# Trick the listCheckBox best size calculations
167+
tmp = self.componentSortOrderBox.GetStrings()
168+
self.componentSortOrderBox.SetItems([])
169+
self.Layout()
170+
self.componentSortOrderBox.SetItems(tmp)
171+
165172

166173
# Implementing ExtraFieldsPanelBase
167174
class ExtraFieldsPanel(dialog_base.ExtraFieldsPanelBase):
@@ -225,3 +232,10 @@ def OnBoardVariantFieldChange(self, event):
225232
variant_set.add(field_dict[selection])
226233
self.boardVariantWhitelist.SetItems(list(variant_set))
227234
self.boardVariantBlacklist.SetItems(list(variant_set))
235+
236+
def OnSize(self, event):
237+
# Trick the listCheckBox best size calculations
238+
tmp = self.extraFieldsList.GetStrings()
239+
self.extraFieldsList.SetItems([])
240+
self.Layout()
241+
self.extraFieldsList.SetItems(tmp)

InteractiveHtmlBom/dialog_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ class MyApp(wx.App):
55
def OnInit(self):
66
frame = SettingsDialog(None, lambda x: None)
77
if frame.ShowModal() == wx.ID_OK:
8-
print "Should generate bom"
8+
print("Should generate bom")
99
frame.Destroy()
1010
return True
1111

settings_dialog.fbp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1835,7 +1835,7 @@
18351835
<event name="OnRightDown"></event>
18361836
<event name="OnRightUp"></event>
18371837
<event name="OnSetFocus"></event>
1838-
<event name="OnSize"></event>
1838+
<event name="OnSize">OnSize</event>
18391839
<event name="OnUpdateUI"></event>
18401840
<object class="wxBoxSizer" expanded="1">
18411841
<property name="minimum_size"></property>
@@ -3608,7 +3608,7 @@
36083608
<event name="OnRightDown"></event>
36093609
<event name="OnRightUp"></event>
36103610
<event name="OnSetFocus"></event>
3611-
<event name="OnSize"></event>
3611+
<event name="OnSize">OnSize</event>
36123612
<event name="OnUpdateUI"></event>
36133613
<object class="wxBoxSizer" expanded="1">
36143614
<property name="minimum_size"></property>

0 commit comments

Comments
 (0)