Net Highlights Not Applied to Pads

[MikahB]

In the Net List, there is an option on each row to set a custom color (which is very helpful). While the color-selection works, the color is never actually rendered.

I was able to make a small change to drawFootprint which resolves this:

Original Code:

if (pad.layers.includes(layer)) {
    drawPad(ctx, pad, colors.pad, outline);
...

Updated Code:

if (pad.layers.includes(layer)) {
    var padColor = (highlight) ? colors.pad : (settings.netColors[pad.net] || colors.pad);
    drawPad(ctx, pad, padColor, outline);
...

This works on both the interactive display and when saving images.

[qu1ck]

I seem to remember this was intentional but I can't recall why. It does look much better if pads are colored too. Please send a PR.

[MikahB]

I seem to remember this was intentional but I can't recall why. It does look much better if pads are colored too. Please send a PR.

I wondered if that might be the case, but I couldn't think of a reason to not use them - or at least it seemed more intuitive that the colors would apply.

I've not done a PR outside of my own stuff before, but I'll get one in - hopefully in a way that works!