Enhance test coverage

Author: openscript

src/components/previews/TablePreview.test.tsx

@@ -62,12 +62,17 @@ describe('TablePreview', () => {
       validation: [
         { column: 'email', row: 0, message: 'Contains duplicates' },
         { column: 'email', row: 1, message: 'Contains duplicates' },
+        { column: 'email', row: 1, message: 'No example address, please' },
         { column: 'forename', row: 1, message: 'Forename is required' }
       ]
     });
     const tableBody = container.querySelector('tbody');
 
     expect(tableBody?.children[1].children[0]).toHaveClass('error');
     expect(tableBody?.children[1].children[0]).toHaveAttribute('title', 'Forename is required');
+    expect(tableBody?.children[1].children[2]).toHaveAttribute(
+      'title',
+      'Contains duplicates;No example address, please'
+    );
   });
 });

src/components/previews/TablePreview.tsx

@@ -16,7 +16,7 @@ export const TablePreview: React.FC<TablePreviewProps> = (props) => {
 
   const Cell: React.FC<{ columnKey: string; rowIndex: number }> = (props) => {
     const errors = getCellValidationError(props.columnKey, props.rowIndex);
-    const messages = errors?.map((e) => e?.message).join(';');
+    const messages = errors?.map((e) => e.message).join(';');
 
     return (
       <td className={messages ? 'error' : ''} title={messages}>

src/middlewares/validatorMiddleware.test.ts

@@ -13,7 +13,8 @@ describe('validatorMiddleware', () => {
   const middleware = createValidatorMiddleware<TestType>();
   const parsed: TestType[] = [
     { forename: 'Hans', surname: 'Muster', email: '[email protected]' },
-    { forename: 'Heidi', surname: 'Muster', email: '[email protected]' }
+    { forename: 'Heidi', surname: 'Muster', email: '[email protected]' },
+    { forename: 'Joe', surname: 'Doe', email: '[email protected]' }
   ];
 
   it('should return an empty array if there are no errors', () => {
@@ -53,7 +54,7 @@ describe('validatorMiddleware', () => {
 
     expect(dispatchMock).toBeCalledWith({
       type: 'setValidation',
-      errors: [{ column: 'forename', row: 1, message: "No 'Hans' allowed" }]
+      errors: [{ column: 'forename', row: 0, message: "No 'Hans' allowed" }]
     });
   });
 });

src/middlewares/validatorMiddleware.ts

@@ -28,7 +28,7 @@ const validateColumn = <T>(key: keyof T, data: T[keyof T][], rules?: Rule[]): Va
       } else if (typeof (r.constraint as CallbackConstraint).callback === 'function') {
         const callback = (r.constraint as CallbackConstraint).callback;
         values.forEach((v, i) => {
-          if (!callback(v)) {
+          if (callback(v)) {
             errors.push({ column: key, row: i, message: r.message });
           }
         });