Skip to content

Commit 12a5133

Browse files
[Explore] Fit and finish (#10871)
* Recent queries label change Signed-off-by: Paul Sebastian <[email protected]> * remove language tooltip and ppl language ref Signed-off-by: Paul Sebastian <[email protected]> * saved queries dropdown font size reduction for explore Signed-off-by: Paul Sebastian <[email protected]> * open saved search panel title change Signed-off-by: Paul Sebastian <[email protected]> * update jest tests Signed-off-by: Paul Sebastian <[email protected]> * Changeset file for PR #10871 created/updated * update cypress tests to remove language tooltip Signed-off-by: Paul Sebastian <[email protected]> * discover fields header styling update Signed-off-by: Paul Sebastian <[email protected]> * change open saved search to select saved search Signed-off-by: Paul Sebastian <[email protected]> --------- Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
1 parent 83e9c39 commit 12a5133

File tree

22 files changed

+30
-765
lines changed

22 files changed

+30
-765
lines changed

changelogs/fragments/10871.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
fix:
2+
- Explore fit and finish around font and sizing ([#10871](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/10871))

cypress/integration/core_opensearch_dashboards/opensearch_dashboards/apps/explore/02/language_specific_display.spec.js

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,7 @@ import {
1414
getRandomizedWorkspaceName,
1515
setDatePickerDatesAndSearchIfRelevant,
1616
} from '../../../../../../utils/apps/explore/shared';
17-
import {
18-
generateDisplayTestConfiguration,
19-
getLanguageReferenceTestText,
20-
} from '../../../../../../utils/apps/explore/language_specific_display';
17+
import { generateDisplayTestConfiguration } from '../../../../../../utils/apps/explore/language_specific_display';
2118
import { prepareTestSuite } from '../../../../../../utils/helpers';
2219

2320
const workspaceName = getRandomizedWorkspaceName();
@@ -82,12 +79,6 @@ export const runDisplayTests = () => {
8279
config.sort ? 'exist' : 'not.exist'
8380
);
8481

85-
// testing the language information popup button
86-
cy.getElementByTestId('exploreLanguageReference').click();
87-
cy.get('.euiPopoverTitle').contains('Syntax options').should('be.visible');
88-
cy.get('.euiPanel').contains(getLanguageReferenceTestText(config.language));
89-
cy.getElementByTestId('exploreLanguageReference').click();
90-
9182
// testing the saved queries management button
9283
cy.getElementByTestId('queryPanelFooterSaveQueryButton').click();
9384
cy.getElementByTestId('saved-query-management-popover').should('be.visible');

cypress/integration/core_opensearch_dashboards/opensearch_dashboards/apps/explore/04/queries_ui.spec.js

Lines changed: 0 additions & 94 deletions
This file was deleted.

src/plugins/data/public/ui/saved_query_management/saved_query_management_component.tsx

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ interface Props {
7070
closeMenuPopover: () => void;
7171
saveQuery: (savedQueryMeta: SavedQueryMeta, saveAsNew?: boolean) => Promise<void>;
7272
saveQueryIsDisabled?: boolean;
73+
textSize?: React.ComponentProps<typeof EuiText>['size'];
7374
}
7475

7576
export function SavedQueryManagementComponent({
@@ -84,6 +85,7 @@ export function SavedQueryManagementComponent({
8485
useNewSavedQueryUI,
8586
saveQuery,
8687
saveQueryIsDisabled,
88+
textSize = 's',
8789
}: Props) {
8890
const [savedQueries, setSavedQueries] = useState([] as SavedQuery[]);
8991
const [count, setTotalCount] = useState(0);
@@ -243,9 +245,11 @@ export function SavedQueryManagementComponent({
243245
);
244246
}}
245247
>
246-
{i18n.translate('data.saved_query_management.save_query_item_label', {
247-
defaultMessage: 'Save query',
248-
})}
248+
<EuiText size={textSize}>
249+
{i18n.translate('data.saved_query_management.save_query_item_label', {
250+
defaultMessage: 'Save query',
251+
})}
252+
</EuiText>
249253
</EuiButtonEmpty>
250254
</div>
251255
<div>
@@ -267,9 +271,11 @@ export function SavedQueryManagementComponent({
267271
);
268272
}}
269273
>
270-
{i18n.translate('data.saved_query_management.open_query_item_label', {
271-
defaultMessage: 'Open query',
272-
})}
274+
<EuiText size={textSize}>
275+
{i18n.translate('data.saved_query_management.open_query_item_label', {
276+
defaultMessage: 'Open query',
277+
})}
278+
</EuiText>
273279
</EuiButtonEmpty>
274280
</div>
275281
</EuiListGroup>

src/plugins/explore/public/application/components/recent_query_selector.tsx

Lines changed: 0 additions & 32 deletions
This file was deleted.
Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,8 @@
33
* SPDX-License-Identifier: Apache-2.0
44
*/
55

6-
export * from './ppl_reference';
6+
.exploreSidebar__headerTitle {
7+
&__text {
8+
font-weight: 600;
9+
}
10+
}

src/plugins/explore/public/components/fields_selector/discover_field_header.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import React, { useCallback } from 'react';
77
import { i18n } from '@osd/i18n';
88
import { EuiFlexGroup, EuiFlexItem, EuiButtonIcon, EuiText } from '@elastic/eui';
99
import { useOpenSearchDashboards } from '../../../../opensearch_dashboards_react/public';
10+
import './discover_field_header.scss';
1011

1112
export interface IDiscoverFieldHeaderProps {
1213
onCollapse?: () => void;
@@ -40,8 +41,8 @@ export function DiscoverFieldHeader({ onCollapse }: IDiscoverFieldHeaderProps) {
4041
return (
4142
<EuiFlexGroup responsive={false} gutterSize="xs">
4243
<EuiFlexItem>
43-
<EuiText size="xs">
44-
<h5>{fieldsHeaderText}</h5>
44+
<EuiText size="s" className="exploreSidebar__headerTitle__text">
45+
{fieldsHeaderText}
4546
</EuiText>
4647
</EuiFlexItem>
4748
<EuiFlexItem grow={false}>

src/plugins/explore/public/components/query_panel/query_panel_widgets/language_reference/index.ts

Lines changed: 0 additions & 6 deletions
This file was deleted.

src/plugins/explore/public/components/query_panel/query_panel_widgets/language_reference/language_reference.scss

Lines changed: 0 additions & 14 deletions
This file was deleted.

src/plugins/explore/public/components/query_panel/query_panel_widgets/language_reference/language_reference.stories.tsx

Lines changed: 0 additions & 46 deletions
This file was deleted.

0 commit comments

Comments
 (0)