Improve dashboard admin UI settings implementation

Signed-off-by: Owen Wang <[email protected]>

Author: FriedhelmWS

src/core/server/ui_settings/saved_objects/permission_controlled_ui_settings_wrapper.ts

@@ -53,12 +53,12 @@ export class PermissionControlledUiSettingsWrapper {
     ): Promise<SavedObjectsUpdateResponse<T>> => {
       if (type === 'config' && id === DASHBOARD_ADMIN_SETTINGS_ID) {
         try {
-          return ((await wrapperOptions.client.update<SavedObject<T>>(
+          return await wrapperOptions.client.update<T>(
             type,
             DASHBOARD_ADMIN_SETTINGS_ID,
             attributes,
             options
-          )) as unknown) as SavedObjectsUpdateResponse<T>;
+          );
         } catch (error) {
           if (SavedObjectsErrorHelpers.isNotFoundError(error)) {
             return this.createPermissionUiSetting(attributes, options, wrapperOptions);

src/core/server/ui_settings/ui_settings_client.ts

@@ -348,10 +348,10 @@ export class UiSettingsClient implements IUiSettingsClient {
         this.log.warn(
           `Deprecation warning: The setting "${key}" has multiple scopes. Please specify a scope when updating it.`
         );
-      } else if (this.userLevelSettingsKeys.includes(key)) {
-        groupedChanges[UiSettingScope.USER][key] = val;
       } else if (this.adminUiSettingsKeys.includes(key)) {
         groupedChanges[UiSettingScope.DASHBOARD_ADMIN][key] = val;
+      } else if (this.userLevelSettingsKeys.includes(key)) {
+        groupedChanges[UiSettingScope.USER][key] = val;
       } else if (this.workspaceLevelSettingsKeys.includes(key)) {
         groupedChanges[UiSettingScope.WORKSPACE][key] = val;
       } else {

src/core/server/ui_settings/ui_settings_service.ts

@@ -101,6 +101,8 @@ export class UiSettingsService
     // Use uiSettings.defaults from the config file
     this.validateAndUpdateConfiguredDefaults(config.uiSettingsConfig.defaults);
 
+    this.register(getAIFeaturesSetting());
+
     const permissionControlledUiSettingsWrapper = new PermissionControlledUiSettingsWrapper(
       config.savedObjectsConfig.permission.enabled
     );
@@ -111,8 +113,6 @@ export class UiSettingsService
       permissionControlledUiSettingsWrapper.wrapperFactory
     );
 
-    this.register(getAIFeaturesSetting());
-
     return {
       register: this.register.bind(this),
     };

src/plugins/advanced_settings/public/management_app/advanced_settings.tsx

@@ -202,7 +202,11 @@ export class AdvancedSettingsComponent extends Component<
           isCustom: config.isCustom(setting[0]),
           isOverridden: config.isOverridden(setting[0]),
           isPermissionControlled:
-            all[setting[0]].scope === UiSettingScope.DASHBOARD_ADMIN && !isDashboardAdmin,
+            ((typeof all[setting[0]].scope === 'string' &&
+              all[setting[0]].scope === UiSettingScope.DASHBOARD_ADMIN) ||
+              (Array.isArray(all[setting[0]].scope) &&
+                (all[setting[0]].scope || []).includes(UiSettingScope.DASHBOARD_ADMIN))) &&
+            !isDashboardAdmin,
           userSettingsEnabled,
         });
       })

src/plugins/query_enhancements/public/query_assist/utils/create_extension.tsx

@@ -6,7 +6,7 @@
 import { i18n } from '@osd/i18n';
 import { ENABLE_AI_FEATURES, HttpSetup } from 'opensearch-dashboards/public';
 import React, { useCallback, useEffect, useState } from 'react';
-import { BehaviorSubject, of } from 'rxjs';
+import { BehaviorSubject, of, combineLatest } from 'rxjs';
 import { useObservable } from 'react-use';
 import { distinctUntilChanged, map, startWith, switchMap } from 'rxjs/operators';
 import { DATA_STRUCTURE_META_TYPES, DEFAULT_DATA } from '../../../../data/common';
@@ -133,8 +133,8 @@ export const createQueryAssistExtension = (
       }
     },
     isEnabled$: () =>
-      getAvailableLanguages$(http, data).pipe(
-        map((languages) => languages.length > 0 && assistantEnabled$.value)
+      combineLatest([getAvailableLanguages$(http, data), assistantEnabled$]).pipe(
+        map(([languages, enabled]) => languages.length > 0 && enabled)
       ),
     getComponent: (dependencies) => {
       // only show the component if user is on a supported language.